Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1449933002: Fix leak in FirstWebContentsProfiler introduced by special recording for deprecated v1 startup stat… (Closed)

Created:
5 years, 1 month ago by gab
Modified:
5 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix leak in FirstWebContentsProfiler introduced by special recording for deprecated v1 startup stats. BUG=556564 Committed: https://crrev.com/e7d2c4ed76958adb6d684de8261b5a473eb0b015 Cr-Commit-Position: refs/heads/master@{#359907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/metrics/first_web_contents_profiler.cc View 1 chunk +7 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1415773004 Patch 160001

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449933002/1
5 years, 1 month ago (2015-11-16 16:37:12 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 17:13:57 UTC) #4
gab
Robert PTAL.
5 years, 1 month ago (2015-11-16 17:19:37 UTC) #6
rkaplow
lgtm
5 years, 1 month ago (2015-11-16 20:32:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449933002/1
5 years, 1 month ago (2015-11-16 20:39:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 20:54:08 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 20:55:03 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e7d2c4ed76958adb6d684de8261b5a473eb0b015
Cr-Commit-Position: refs/heads/master@{#359907}

Powered by Google App Engine
This is Rietveld 408576698