Issue 14499011: Do not use repeated subtractions in mod-i, it hurts performance in general.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14499011: Do not use repeated subtractions in mod-i, it hurts performance in general. (Closed)

Created:
7 years, 7 months ago by Sven Panne

Modified:
7 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Do not use repeated subtractions in mod-i, it hurts performance in general. ARM only: Check for -0 only when really necessary. Tiny code de-duplication. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14479

Patch Set 1 #

Patch Set 2 : Removed unused Label #

Total comments: 1

Patch Set 3 : Rebased #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -65 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1	5 chunks	+12 lines, -35 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		2 chunks	+2 lines, -15 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		2 chunks	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://codereview.chromium.org/14499011/diff/2001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/14499011/diff/2001/src/arm/lithium-codegen-arm.cc#newcode1168 src/arm/lithium-codegen-arm.cc:1168: // Check for x % ...

7 years, 7 months ago (2013-04-29 12:57:07 UTC) #2

Sven Panne

7 years, 7 months ago (2013-04-29 13:45:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r14479 (presubmit successful).

Expand Messages | Collapse Messages