Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 144983002: Fixed chrome://settings/accounts availability for MP. (Closed)

Created:
6 years, 11 months ago by ygorshenin1
Modified:
6 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fixed chrome://settings/accounts availability for MP. BUG=230018 TEST=manual tests on Peppy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247806

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix. #

Patch Set 3 : Added browsertest. #

Total comments: 3

Patch Set 4 : Deleted irrelevant change. #

Patch Set 5 : Fixed proxy_settings_ui. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -17 lines) Patch
M chrome/browser/chromeos/profiles/profile_helper.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/components_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
ygorshenin1
6 years, 11 months ago (2014-01-22 14:01:31 UTC) #1
Nikita (slow)
https://codereview.chromium.org/144983002/diff/1/chrome/browser/chromeos/profiles/profile_helper.h File chrome/browser/chromeos/profiles/profile_helper.h (right): https://codereview.chromium.org/144983002/diff/1/chrome/browser/chromeos/profiles/profile_helper.h#newcode65 chrome/browser/chromeos/profiles/profile_helper.h:65: static bool IsProfileOwner(Profile* profile); nit: IsOwnerProfile seems to fit ...
6 years, 11 months ago (2014-01-22 14:45:29 UTC) #2
dzhioev (left Google)
LGTM with nit https://codereview.chromium.org/144983002/diff/1/chrome/browser/chromeos/profiles/profile_helper.cc File chrome/browser/chromeos/profiles/profile_helper.cc (right): https://codereview.chromium.org/144983002/diff/1/chrome/browser/chromeos/profiles/profile_helper.cc#newcode123 chrome/browser/chromeos/profiles/profile_helper.cc:123: return usr->email() == mgr->GetOwnerEmail(); Please use ...
6 years, 11 months ago (2014-01-23 13:25:07 UTC) #3
ygorshenin1
PTAL https://codereview.chromium.org/144983002/diff/1/chrome/browser/chromeos/profiles/profile_helper.cc File chrome/browser/chromeos/profiles/profile_helper.cc (right): https://codereview.chromium.org/144983002/diff/1/chrome/browser/chromeos/profiles/profile_helper.cc#newcode123 chrome/browser/chromeos/profiles/profile_helper.cc:123: return usr->email() == mgr->GetOwnerEmail(); On 2014/01/23 13:25:08, dzhioev ...
6 years, 11 months ago (2014-01-27 09:13:14 UTC) #4
Nikita (slow)
lgtm
6 years, 11 months ago (2014-01-27 15:25:20 UTC) #5
ygorshenin1
Nikita, Pavel, could you please take a look at the added browsertest?
6 years, 10 months ago (2014-01-28 11:08:35 UTC) #6
Nikita (slow)
test lgtm https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc File chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc (right): https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc#newcode75 chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc:75: ui_test_utils::NavigateToURL(browser, nit: Does this method guarantee that ...
6 years, 10 months ago (2014-01-28 12:24:30 UTC) #7
ygorshenin1
https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc File chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc (right): https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc#newcode75 chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc:75: ui_test_utils::NavigateToURL(browser, This method blocks until navigation is finished. On ...
6 years, 10 months ago (2014-01-28 13:32:53 UTC) #8
ygorshenin1
https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc File chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc (right): https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc#newcode75 chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc:75: ui_test_utils::NavigateToURL(browser, + also it follows the way how https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/options/options_ui_browsertest.cc&l=87 ...
6 years, 10 months ago (2014-01-28 13:47:58 UTC) #9
Nikita (slow)
On 2014/01/28 13:47:58, ygorshenin1 wrote: > https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc > File chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc > (right): > > https://codereview.chromium.org/144983002/diff/270001/chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc#newcode75 ...
6 years, 10 months ago (2014-01-28 14:29:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/144983002/280001
6 years, 10 months ago (2014-01-28 18:24:46 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=195602
6 years, 10 months ago (2014-01-28 22:23:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/144983002/280001
6 years, 10 months ago (2014-01-29 07:51:31 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=195881
6 years, 10 months ago (2014-01-29 12:25:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/144983002/300001
6 years, 10 months ago (2014-01-29 15:46:16 UTC) #15
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 01:45:15 UTC) #16
Message was sent while issue was closed. 
Change committed as 247806

Powered by Google App Engine
This is Rietveld 408576698