data_with_base_url

data_with_base_url

WIP

BUG=522567
Closing in favour of https://codereview.chromium.org/1304373007/

[mnaganov (inactive), 2015-11-16 18:38:54]

mnaganov@chromium.org changed reviewers:
+ mnaganov@chromium.org

[mnaganov (inactive), 2015-11-16 18:38:55]

https://codereview.chromium.org/1449793002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/navigation_entry_impl.h (right):

https://codereview.chromium.org/1449793002/diff/20001/content/browser/frame_h...
content/browser/frame_host/navigation_entry_impl.h:85: void
SetDataURLWithBaseURL(const GURL& url) override;
The 'with' part is confusing, it sounds as you are setting both URLs here.
Should it be 'DataOfLoadDataWithBaseURL'?

[Charlie Reis, 2015-11-19 20:08:06]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2015-11-19 20:08:07]

I've been looking more closely at this, and there's another concern-- Android is
serializing GetBaseURLForDataURL() in state_serializer.cc.  That means any
changes we make to where these URLs are stored affects data stored on disk, and
we would need to be super careful about migrating data, introducing a new format
version, etc.  I would be very hesitant to go down that path unless we're sure
the other approach won't work.  Given your other hesitations in comment 69 of
the bug, let's put this on hold.

I'm digging into your previous approach a bit more in patch 10 of
https://codereview.chromium.org/1304373007/, to understand and see if there's
more promise there.  I'll post a followup there shortly.

[boliu, 2015-11-19 20:22:23]

On 2015/11/19 20:08:07, Charlie Reis wrote:
> I've been looking more closely at this, and there's another concern-- Android
is
> serializing GetBaseURLForDataURL() in state_serializer.cc.

Addressing state_serializer.cc specifically. It does have a version (and
apparently the last time it was updated as more than 2 years ago)

And it should be ok to just drop older versions from disk, which is exactly what
the current code does with the version check. No need for complex
versioning/migrations or whatnot. Webview's state_serializer promise is not as
strong as chrome's profiles.

> That means any
> changes we make to where these URLs are stored affects data stored on disk,
and
> we would need to be super careful about migrating data, introducing a new
format
> version, etc.  I would be very hesitant to go down that path unless we're sure
> the other approach won't work.  Given your other hesitations in comment 69 of
> the bug, let's put this on hold.
> 
> I'm digging into your previous approach a bit more in patch 10 of
> https://codereview.chromium.org/1304373007/, to understand and see if there's
> more promise there.  I'll post a followup there shortly.

[boliu, 2015-11-20 19:07:08]

Description was changed from

==========
data_with_base_url

WIP

BUG=522567
==========

to

==========
data_with_base_url

WIP

BUG=522567

Closing in favour of https://codereview.chromium.org/1304373007/
==========