Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1449693002: Updating Mojo/Base's Sha1 functionality to hash entire files. (Closed)

Created:
5 years, 1 month ago by Sean Klein
Modified:
5 years, 1 month ago
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Updating Mojo/Base's Sha1 functionality to hash entire files. BUG=#396 R=phosek@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cfeba3cce284f8a4d382337201d479768bb0eb77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M base/sha1.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/sha1_portable.cc View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sean Klein
5 years, 1 month ago (2015-11-14 03:12:02 UTC) #2
Petr Hosek
lgtm
5 years, 1 month ago (2015-11-14 20:58:29 UTC) #3
Sean Klein
Committed patchset #1 (id:1) manually as cfeba3cce284f8a4d382337201d479768bb0eb77 (presubmit successful).
5 years, 1 month ago (2015-11-15 21:08:01 UTC) #4
viettrungluu
No tests? (Granted, we don't currently build/run base_unittests, but that in itself is going to ...
5 years, 1 month ago (2015-11-16 17:07:53 UTC) #6
Sean Klein
5 years, 1 month ago (2015-11-16 17:14:00 UTC) #7
Message was sent while issue was closed.
On 2015/11/16 17:07:53, viettrungluu wrote:
> No tests?
> 
> (Granted, we don't currently build/run base_unittests, but that in itself is
> going to be a problem if we're going to be modifying base.)

I discussed this offline with Phosek -- I suppose I should have been a bit more
proactive about it.

Are you okay with me building/running base_unittests as a part of Mojo? I was
going to ask you first, since it will probably add nonzero delay to the Mojo
test time.

Powered by Google App Engine
This is Rietveld 408576698