Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp

Issue 1449623002: IntersectionObserver: second cut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Add RuntimeEnabled flags to all idl's, fix test expectations. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp
similarity index 63%
copy from third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp
copy to third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp
index 72614664832935970cfb9554d5a269ca83bca5e7..5abf33f35096b3a9551c3c46dffb39c386cbe3d7 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp
@@ -1,21 +1,18 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
-
-#include "bindings/core/v8/V8PerformanceObserverCallback.h"
+#include "bindings/core/v8/V8IntersectionObserverCallback.h"
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/V8PerformanceObserver.h"
-#include "bindings/core/v8/V8PerformanceObserverEntryList.h"
+#include "bindings/core/v8/V8IntersectionObserver.h"
#include "core/dom/ExecutionContext.h"
#include "wtf/Assertions.h"
namespace blink {
-V8PerformanceObserverCallback::V8PerformanceObserverCallback(v8::Local<v8::Function> callback, v8::Local<v8::Object> owner, ScriptState* scriptState)
+V8IntersectionObserverCallback::V8IntersectionObserverCallback(v8::Local<v8::Function> callback, v8::Local<v8::Object> owner, ScriptState* scriptState)
: ActiveDOMCallback(scriptState->executionContext())
, m_callback(scriptState->isolate(), callback)
, m_scriptState(scriptState)
@@ -24,11 +21,11 @@ V8PerformanceObserverCallback::V8PerformanceObserverCallback(v8::Local<v8::Funct
m_callback.setWeak(this, &setWeakCallback);
}
-V8PerformanceObserverCallback::~V8PerformanceObserverCallback()
+V8IntersectionObserverCallback::~V8IntersectionObserverCallback()
{
}
-void V8PerformanceObserverCallback::handleEvent(PerformanceObserverEntryList* entries, PerformanceObserver* observer)
+void V8IntersectionObserverCallback::handleEvent(const HeapVector<Member<IntersectionObserverEntry>>& entries, IntersectionObserver& observer)
{
if (!canInvokeCallback())
return;
@@ -39,7 +36,7 @@ void V8PerformanceObserverCallback::handleEvent(PerformanceObserverEntryList* en
if (m_callback.isEmpty())
return;
- v8::Local<v8::Value> observerHandle = toV8(observer, m_scriptState->context()->Global(), m_scriptState->isolate());
+ v8::Local<v8::Value> observerHandle = toV8(&observer, m_scriptState->context()->Global(), m_scriptState->isolate());
if (observerHandle.IsEmpty()) {
if (!isScriptControllerTerminating())
CRASH();
@@ -61,14 +58,14 @@ void V8PerformanceObserverCallback::handleEvent(PerformanceObserverEntryList* en
ScriptController::callFunction(m_scriptState->executionContext(), m_callback.newLocal(m_scriptState->isolate()), thisObject, 2, argv, m_scriptState->isolate());
}
-void V8PerformanceObserverCallback::setWeakCallback(const v8::WeakCallbackInfo<V8PerformanceObserverCallback>& data)
+void V8IntersectionObserverCallback::setWeakCallback(const v8::WeakCallbackInfo<V8IntersectionObserverCallback>& data)
{
data.GetParameter()->m_callback.clear();
}
-DEFINE_TRACE(V8PerformanceObserverCallback)
+DEFINE_TRACE(V8IntersectionObserverCallback)
{
- PerformanceObserverCallback::trace(visitor);
+ IntersectionObserverCallback::trace(visitor);
ActiveDOMCallback::trace(visitor);
}

Powered by Google App Engine
This is Rietveld 408576698