third_party/WebKit/LayoutTests/fast/dom/intersection-observer.html - Issue 1449623002: IntersectionObserver: second cut.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/intersection-observer.html

Issue 1449623002: IntersectionObserver: second cut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Clarify the tear-down path for observers and observations. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/intersection-observer-expected.txt » ('j') | third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3

	4 <div id="top_div" style="background-color:blue;position:absolute; top:50px; left :20px; width:600px; height:800px">

	5 </div>

	6

	7 <div id="target_div" style="background-color:red;position:absolute; top:855px; left:66px; width:300px; height:250px">

	8 </div>

	9

	10 <script>

	11 window.jsTestIsAsync = true;

	12

	13 var entries = [];

	14 var expectedEntries = [

	15 {

	16 time:'mark',

	17 boundingClientRect:{top:855, right:366, bottom: 1105, left: 66},

	18 intersectionRect:{top:855, right:366, bottom: 1000, left: 66},

	19 rootBounds: {top:400, right:785, bottom:1000, left:0},

	20 target: document.getElementById('target_div')

	21 }

	22 ];

	23

	24 var a = {}, b = {};

	25 function shouldBeClientRect(name, value1, value2)

	26 {

	27 a[name] = value1;

	28 b[name] = value2;

	29 shouldBe('a.'+name+'.top', 'b.'+name+'.top');

	30 shouldBe('a.'+name+'.right', 'b.'+name+'.right');

	31 shouldBe('a.'+name+'.bottom', 'b.'+name+'.bottom');

	32 shouldBe('a.'+name+'.left', 'b.'+name+'.left');

	33 }

	34

	35 function testIntersectionObserver()

	36 {

	37 var observer = new IntersectionObserver(intersectionCallback, {});

	38

	39 function intersectionCallback(changes)

	40 {

	41 entries = entries.concat(changes);

	42 if (entries.length != expectedEntries.length)

	43 return;

	44 shouldBe('entries[0].time', '0');

	45 shouldBeClientRect('bounds', changes[0].boundingClientRect, expectedEntr ies[0].boundingClientRect);

	46 shouldBeClientRect('intersection', changes[0].intersectionRect, expected Entries[0].intersectionRect);

	47 shouldBeClientRect('rootBounds', changes[0].rootBounds, expectedEntries[ 0].rootBounds);

	48 shouldBe('entries[0].target', 'expectedEntries[0].target');

	49 testRunner.notifyDone();

	50 }

	51

	52 var target_div = document.getElementById('target_div');

	53 observer.observe(target_div);

	54 window.setTimeout(function() { window.scrollBy(0, 400); }, 0);

	55 }

	56

	57 description("This tests that IntersectionObserver gets called the right number o f times.");

	58

	59 testIntersectionObserver();

	60 testRunner.waitUntilDone();

	61 </script>
	eae 2015/11/16 23:34:44 This test is pretty sad as it doesn't tests much. This test is pretty sad as it doesn't tests much. Also try to avoid data driven tests as those are hard to reason about and debug. szager1 2015/11/19 19:15:37 Agreed, this test needs some work. Show quoted text On 2015/11/16 23:34:44, eae wrote: > This test is pretty sad as it doesn't tests much. Also try to avoid data driven > tests as those are hard to reason about and debug. Agreed, this test needs some work.
OLD	NEW