IntersectionObserver: second cut.

third_party/WebKit/Source/core/dom/IntersectionObserverEntry.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IntersectionObserverEntry_h
+#define IntersectionObserverEntry_h
+
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/dom/ClientRect.h"
+#include "platform/geometry/IntRect.h"
+#include "platform/heap/Handle.h"
+
+namespace blink {
+
+class Element;
+
+class IntersectionObserverEntry : public GarbageCollectedFinalized<IntersectionObserverEntry>, public ScriptWrappable {
+    DEFINE_WRAPPERTYPEINFO();
+public:
+    IntersectionObserverEntry(double, const IntRect&, const IntRect&, const IntRect&, Element*);
+    ~IntersectionObserverEntry();
+
+    double time() { return m_time; }
+    ClientRect* boundingClientRect() { return ClientRect::create(m_boundingClientRect); }

[esprehn, 2015/12/12 00:14:16]

these objects need to be stable, you want to store the ClientRect objects as
members and just return them, not malloc and wrap a new one every time.

you should add tests for that too.

assert(entry.boundingClientRect == entry.boundingClientRect)

[szager1, 2015/12/16 19:15:37]

Done, and added this check to
LayoutTests/intersection-observer/same-document-no-root.hml

+    ClientRect* rootBounds() { return ClientRect::create(m_rootBounds); }

[esprehn, 2015/12/12 00:14:16]

ditto

[szager1, 2015/12/16 19:15:37]

Done.

+    ClientRect* intersectionRect() { return ClientRect::create(m_intersectionRect); }
+    Element* target() { return m_target.get(); }
+
+    DECLARE_VIRTUAL_TRACE();
+
+private:
+    const double m_time;
+    const IntRect m_boundingClientRect;
+    const IntRect m_rootBounds;
+    const IntRect m_intersectionRect;
+    const RefPtrWillBeMember<Element> m_target;
+};
+
+} // namespace blink
+
+#endif // IntersectionObserverEntry_h