src/IceTargetLoweringX86BaseImpl.h - Issue 1449523002: Eliminate stack adjustment for float-returning functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 1449523002: Eliminate stack adjustment for float-returning functions (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review comments addressed. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 6cc0a491981474d1e72e828a0408bad59bf2cc36..1bddc51cc0245e1897e57db5b7b2bf7e76b17384 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -5199,6 +5199,9 @@ template <class Machine>

void TargetX86Base<Machine>::lowerUnreachable(

const InstUnreachable * /*Inst*/) {

_ud2();

+ // Add a fake use of esp to make sure esp adjustments after the unreachable

+ // do not get dead-code eliminated.

+ keepEspLiveAtExit();

}

template <class Machine>

« no previous file with comments | « src/IceTargetLoweringX86Base.h ('k') | no next file » | no next file with comments »