Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14495004: Remove left-over PageCache stuff (Closed)

Created:
7 years, 8 months ago by adamk
Modified:
7 years, 8 months ago
CC:
blink-reviews, jamesr, abarth_chromum.org, gavinp+loader_chromium.org, Nate Chapin, jeez, jochen+watch_chromium.org, eseidel, ojan
Visibility:
Public.

Description

Remove left-over PageCache stuff PageCache was removed in r148973. This patch removes the rest of the Settings code as well as various comments/logging code. Finally, it gets rid of LayoutTests that are no longer exercising anything interesting. In a few cases, the test still seems to be testing interesting behavior; these have been updated to remove their reference to the UsesPageCache pref. BUG=229605 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1577 lines) Patch
M LayoutTests/TestExpectations View 8 chunks +0 lines, -20 lines 0 comments Download
D LayoutTests/batterystatus/event-after-navigation.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/batterystatus/event-after-navigation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/batterystatus/resources/event-after-navigation-new.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/batterystatus/script-tests/event-after-navigation.js View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/compositing/iframes/page-cache-layer-tree.html View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/compositing/iframes/page-cache-layer-tree-expected.txt View 1 chunk +0 lines, -103 lines 0 comments Download
D LayoutTests/compositing/iframes/resources/page-cache-helper.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/compositing/iframes/resources/page-cache-iframe.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/DeviceMotion/no-page-cache.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/DeviceMotion/no-page-cache-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/DeviceMotion/resources/cached-page-1.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/DeviceMotion/resources/cached-page-2.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/dom/DeviceMotion/script-tests/no-page-cache.js View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/event-after-navigation.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/event-after-navigation-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/no-page-cache.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/no-page-cache-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/resources/cached-page-1.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/resources/cached-page-2.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/resources/event-after-navigation-new.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/script-tests/event-after-navigation.js View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/DeviceOrientation/script-tests/no-page-cache.js View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/Geolocation/no-page-cache.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/Geolocation/no-page-cache-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/Geolocation/script-tests/no-page-cache.js View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/events/onunload-back-to-page-cache.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/events/onunload-back-to-page-cache-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/events/script-tests/onunload-back-to-page-cache.js View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/frames/frame-crash-with-page-cache.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/frames/frame-crash-with-page-cache-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/history/back-forward-reset-after-error-handling.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/history/timed-refresh-in-cached-frame.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/history/timed-refresh-in-cached-frame-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/images/animated-gif-restored-from-bfcache.html View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/fast/images/animated-gif-restored-from-bfcache-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/loader/display-image-unset-allows-cached-image-load.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/loader/display-image-unset-allows-cached-image-load-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/loader/frames-with-unload-handlers-in-page-cache.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/loader/image-in-page-cache.html View 1 chunk +0 lines, -70 lines 0 comments Download
D LayoutTests/fast/loader/image-in-page-cache-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/loader/input-element-page-cache-crash.html View 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/fast/loader/input-element-page-cache-crash-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/loader/scroll-position-restored-on-back.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/loader/unschedule-relayout-after-unload.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/media/media-query-list-04.html View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/fast/media/media-query-list-04-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/viewport/viewport-128.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/viewport/viewport-128-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/media/reload-after-dialog.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/go-back-to-error-page.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/navigation/resources/https-in-page-cache-1.php View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/http/tests/navigation/resources/https-in-page-cache-2.php View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/http/tests/navigation/resources/https-in-page-cache-3.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/media/crash-closing-page-with-media-as-plugin-fallback-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/media/resources/video-with-poster-as-object-fallback.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/plugins/crash-restoring-plugin-page-from-page-cache.html View 1 chunk +0 lines, -94 lines 0 comments Download
D LayoutTests/plugins/crash-restoring-plugin-page-from-page-cache-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-page-cache-works.html View 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/plugins/netscape-plugin-page-cache-works-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/plugins/resources/go-back.html View 1 chunk +0 lines, -14 lines 0 comments Download
D ManualTests/frame-layout-on-back.html View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/WebKit/chromium/public/WebSettings.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/HistoryController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/page/Settings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/platform/Logging.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/Logging.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/public/WebPreferences.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adamk
7 years, 8 months ago (2013-04-25 20:56:31 UTC) #1
eseidel
lgtm
7 years, 8 months ago (2013-04-25 21:08:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/14495004/1
7 years, 8 months ago (2013-04-25 21:08:58 UTC) #3
commit-bot: I haz the power
Presubmit check for 14495004-1 failed and returned exit status 1. INFO:root:Found 16 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-25 21:09:26 UTC) #4
abarth-chromium
changes to public/ LGTM
7 years, 8 months ago (2013-04-25 21:19:04 UTC) #5
adamk
7 years, 8 months ago (2013-04-25 21:34:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 manually as r149130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698