[V8] Unify get function name for debugging purpose

[V8] Unify get function name for debugging purpose

Following logic is using for getting function name in JSFunction::GetDebugName:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

JSFunction::GetDebugName is exposed in V8 API and in FunctionMirror interface.

BUG=chromium:17356
R=yangguo@chromium.org,mstarzinger@chromium.org
LOG=Y

Committed: https://crrev.com/89e859fb2b5cf5c30aca3492fdb6e98fa87950a3
Cr-Commit-Position: refs/heads/master@{#32124}

[kozy, 2015-11-13 23:16:05]

Yang, please take a look.

[kozy, 2015-11-14 05:08:01]

Description was changed from

==========
[V8] API StackTrace prefers Function.displayName for frame functionName

Following logic is using for setting functionName of frame in stack trace:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string
then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

BUG=chromium:17356
R=yangguo@chromium.org
==========

to

==========
[V8] Unify get function name for debugging purpose

Following logic is using for getting function name in JSFunction::GetDebugName:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string
then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

BUG=chromium:17356
R=yangguo@chromium.org
LOG=Y
==========

[kozy, 2015-11-14 05:40:56]

I'm still thinking about displayName. From one hand, I can understand arguments
of @bedney in issue thread.
Sometime developers want to use displayName to override function name with
string that describes action, e.g. "Fetching <url>" for function fetch(url).
Make this trick with Function.name looks like hack.
From another hand we should to follow specification.

[kozy, 2015-11-15 00:25:00]

Patchset #3 (id:30001) has been deleted

[kozy, 2015-11-15 00:25:06]

Patchset #2 (id:20001) has been deleted

[kozy, 2015-11-15 00:25:13]

Patchset #1 (id:1) has been deleted

[kozy, 2015-11-15 00:35:00]

Patchset #1 (id:40001) has been deleted

[kozy, 2015-11-15 00:57:44]

Patchset #1 (id:50001) has been deleted

[kozy, 2015-11-15 22:48:11]

Description was changed from

==========
[V8] Unify get function name for debugging purpose

Following logic is using for getting function name in JSFunction::GetDebugName:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string
then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

BUG=chromium:17356
R=yangguo@chromium.org
LOG=Y
==========

to

==========
[V8] Unify get function name for debugging purpose

Following logic is using for getting function name in JSFunction::GetDebugName:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string
then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

JSFunction::GetDebugName is exposed in V8 API and in FunctionMirror interface.

BUG=chromium:17356
R=yangguo@chromium.org
LOG=Y
==========

[kozy, 2015-11-15 23:20:18]

Patchset #2 (id:70001) has been deleted

[Yang, 2015-11-17 06:23:45]

Small nit.

Do I understand correctly that this does not change any behavior that could be
observed from Javascript, but only affects the content of the message object,
stack traces, and the debug name exposed to devtools?

In that case, LGTM.

https://codereview.chromium.org/1449473005/diff/80001/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1449473005/diff/80001/src/debug/mirrors.js#ne...
src/debug/mirrors.js:990: * Returns the displayName if it is set, otherwise
name, otherwise inferred name.
Comment goes over 80-char limit.

[kozy, 2015-11-17 17:15:53]

All done.
In last patch set I've fixed Error.stack property and after that displayName is
used only for DevTools.

https://codereview.chromium.org/1449473005/diff/80001/src/debug/mirrors.js
File src/debug/mirrors.js (right):

https://codereview.chromium.org/1449473005/diff/80001/src/debug/mirrors.js#ne...
src/debug/mirrors.js:990: * Returns the displayName if it is set, otherwise
name, otherwise inferred name.
On 2015/11/17 06:23:45, Yang wrote:
> Comment goes over 80-char limit.

Done.

[kozy, 2015-11-17 17:53:44]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2015-11-17 17:53:45]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1449473005/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-11-17 17:53:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449473005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449473005/100001

[commit-bot: I haz the power, 2015-11-17 18:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 18:02:35]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7817)

[kozy, 2015-11-17 18:16:35]

kozyatinskiy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[kozy, 2015-11-17 18:16:36]

Michael, please take a look.
I need owner lgtm for heap.h.

[kozy, 2015-11-17 18:16:48]

Description was changed from

==========
[V8] Unify get function name for debugging purpose

Following logic is using for getting function name in JSFunction::GetDebugName:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string
then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

JSFunction::GetDebugName is exposed in V8 API and in FunctionMirror interface.

BUG=chromium:17356
R=yangguo@chromium.org
LOG=Y
==========

to

==========
[V8] Unify get function name for debugging purpose

Following logic is using for getting function name in JSFunction::GetDebugName:
1. if function has displayName and its type is string then use it
2. if function has defined property Function.name as value and its type string
then use it
3. otherwise use SharedFunctionInfo::DebugName as functionName.

JSFunction::GetDebugName is exposed in V8 API and in FunctionMirror interface.

BUG=chromium:17356
R=yangguo@chromium.org,mstarzinger@chromium.org
LOG=Y
==========

[Michael Starzinger, 2015-11-19 17:27:37]

LGTM (rubber-stamp on "heap", didn't look at the rest).

[kozy, 2015-11-19 17:29:04]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2015-11-19 17:29:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449473005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449473005/100001

[commit-bot: I haz the power, 2015-11-19 19:32:37]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-11-19 19:32:48]

Patchset 3 (id:??) landed as
https://crrev.com/89e859fb2b5cf5c30aca3492fdb6e98fa87950a3
Cr-Commit-Position: refs/heads/master@{#32124}