Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 144943004: Set thread names to be visible in debuggers (Closed)

Created:
6 years, 10 months ago by apatole
Modified:
6 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Set thread names to be visible in debuggers Like linux, on android we can get the thread names to show up in the debugger by setting the process name for the LWP. This change sets the name of the calling thread using prctl. BUG=332881 R=jam@chromium.org R=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250981

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/threading/platform_thread_android.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Torne
lgtm
6 years, 10 months ago (2014-02-10 12:05:08 UTC) #1
apatole
The CQ bit was checked by apatole@nvidia.com
6 years, 10 months ago (2014-02-11 06:54:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatole@nvidia.com/144943004/1
6 years, 10 months ago (2014-02-11 06:54:27 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 07:25:45 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49446
6 years, 10 months ago (2014-02-11 07:25:46 UTC) #5
apatole
On 2014/02/11 07:25:46, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-11 10:57:47 UTC) #6
Torne
The comment in base/threading/OWNERS suggests jam only wants to insist on reviewing threading_restrictions code. Ask ...
6 years, 10 months ago (2014-02-11 11:12:28 UTC) #7
awong
LGTM
6 years, 10 months ago (2014-02-13 01:12:37 UTC) #8
awong
On 2014/02/13 01:12:37, awong wrote: > LGTM btw, usually much better to just pick one ...
6 years, 10 months ago (2014-02-13 01:12:54 UTC) #9
apatole
The CQ bit was checked by apatole@nvidia.com
6 years, 10 months ago (2014-02-13 05:43:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatole@nvidia.com/144943004/1
6 years, 10 months ago (2014-02-13 05:43:39 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:17:30 UTC) #12
Message was sent while issue was closed.
Change committed as 250981

Powered by Google App Engine
This is Rietveld 408576698