Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/lexer_generator/code_generator.py

Issue 144943003: Experimental parser: remove hacks from replace_tokens_with_gotos. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser
Patch Set: w/ dcarney Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/lexer_generator/dfa_optimizer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/lexer_generator/code_generator.py
diff --git a/tools/lexer_generator/code_generator.py b/tools/lexer_generator/code_generator.py
index 6d07a603233fe8762146ac5af7697d7b446a14d0..0b73881214370e5cfc62f55cc00f47b7933afec4 100644
--- a/tools/lexer_generator/code_generator.py
+++ b/tools/lexer_generator/code_generator.py
@@ -66,31 +66,29 @@ class CodeGenerator:
transitions = sorted(transitions, cmp)
# map transition keys to disjoint ranges and collect stats
disjoint_keys = []
- eos_transition = None
+ unique_transitions = {}
old_transitions = transitions
transitions = []
(class_keys, distinct_keys, ranges) = (0, 0, 0)
for key, transition_id in old_transitions:
- keys = list(key.range_iter(encoding))
- eos_found = False
- for (t, r) in keys:
+ keys = []
+ for (t, r) in key.range_iter(encoding):
if t == 'CLASS':
class_keys += 1
+ keys.append((t, r))
elif t == 'PRIMARY_RANGE':
distinct_keys += r[1] - r[0] + 1
ranges += 1
+ keys.append((t, r))
elif t == 'UNIQUE':
- assert r == 'eos'
- assert len(keys) == 1
- assert eos_transition == None
- eos_transition = transition_id
- eos_found = True
+ assert r == 'no_match' or r == 'eos'
+ assert r not in unique_transitions
+ unique_transitions[r] = transition_id
else:
raise Exception()
- if not eos_found:
+ if keys:
transitions.append((keys, transition_id))
# eos_transitions is for a followup cl
- assert not eos_transition
return {
'node_number' : None,
'original_node_number' : state.node_number(),
@@ -104,7 +102,7 @@ class CodeGenerator:
'switch_transitions' : [],
'deferred_transitions' : [],
'long_char_transitions' : [],
- 'eos_transition' : eos_transition,
+ 'unique_transitions' : unique_transitions,
# state actions
'entry_action' : entry_action,
'match_action' : match_action,
@@ -248,6 +246,8 @@ class CodeGenerator:
dfa_states.append(current_node)
for (key, node_number) in current_node['transitions']:
CodeGenerator.__reorder(node_number, id_map, dfa_states)
+ for node_number in current_node['unique_transitions'].values():
+ CodeGenerator.__reorder(node_number, id_map, dfa_states)
def __build_dfa_states(self):
dfa_states = []
« no previous file with comments | « no previous file | tools/lexer_generator/dfa_optimizer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698