Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 144943003: Experimental parser: remove hacks from replace_tokens_with_gotos. (Closed)

Created:
6 years, 11 months ago by marja
Modified:
6 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Experimental parser: remove hacks from replace_tokens_with_gotos. The hack was for making sure that the state to which we "goto" is connected to the state graph: it avoided doing the replacement for states which have an entry action, and our grammar happened to have such an action, so it worked. After this change, we insert a bogus edge to make the "goto" state connected to the state graph, and remove the "don't replace states which have an entry action" condition. TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18744

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : w/ dcarney #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M tools/lexer_generator/code_generator.py View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M tools/lexer_generator/dfa_optimizer.py View 5 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
marja
6 years, 11 months ago (2014-01-22 12:32:53 UTC) #1
Message was sent while issue was closed.
Committed patchset #3 manually as r18744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698