Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1449413002: Deflake http/tests/misc/script-sync-slow-scripts-onerror.html (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
Nate Chapin, Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake http/tests/misc/script-sync-slow-scripts-onerror.html Cope with sync scripts failing to load in any order, testing instead their collective outcome when finishing up. R=mkwst BUG=555052 Committed: https://crrev.com/a6d9f7fd89c534b988f566cf803c490eb5d403d1 Cr-Commit-Position: refs/heads/master@{#360123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/script-sync-slow-scripts-onerror.html View 1 chunk +14 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/script-sync-slow-scripts-onerror-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look. I have a knack for adding initially flaky network tests, it ...
5 years, 1 month ago (2015-11-17 12:55:14 UTC) #2
Mike West
Looks pretty reasonable. Let's see what the bots think. LGTM!
5 years, 1 month ago (2015-11-17 18:48:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449413002/1
5 years, 1 month ago (2015-11-17 18:53:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 19:00:44 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 19:01:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6d9f7fd89c534b988f566cf803c490eb5d403d1
Cr-Commit-Position: refs/heads/master@{#360123}

Powered by Google App Engine
This is Rietveld 408576698