Allow API functions and events to have entries in _api_features.json

chrome/renderer/extensions/dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/dispatcher.h"
 
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
+#include "base/json/json_reader.h"
+#include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "chrome/common/child_process_logging.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/extensions/api/extension_api.h"
 #include "chrome/common/extensions/background_info.h"
 #include "chrome/common/extensions/extension.h"
@@ skipping 38 matching lines @@
 #include "chrome/renderer/extensions/tab_finder.h"
 #include "chrome/renderer/extensions/tabs_custom_bindings.h"
 #include "chrome/renderer/extensions/tts_custom_bindings.h"
 #include "chrome/renderer/extensions/user_script_slave.h"
 #include "chrome/renderer/extensions/web_request_custom_bindings.h"
 #include "chrome/renderer/extensions/webstore_bindings.h"
 #include "chrome/renderer/resource_bundle_source_map.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/view_type.h"
+#include "grit/common_resources.h"
 #include "grit/renderer_resources.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebString.h"
 #include "third_party/WebKit/Source/Platform/chromium/public/WebURLRequest.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDataSource.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebScopedUserGesture.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSecurityPolicy.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "ui/base/layout.h"
@@ skipping 28 matching lines @@
   v8::Handle<v8::Value> chrome(global->Get(chrome_string));
   if (chrome.IsEmpty() || chrome->IsUndefined()) {
     v8::Handle<v8::Object> chrome_object(v8::Object::New());
     global->Set(chrome_string, chrome_object);
     return chrome_object;
   }
   CHECK(chrome->IsObject());
   return chrome->ToObject();
 }
 
+class TestFeaturesNativeHandler : public ObjectBackedNativeHandler {
+ public:
+  explicit TestFeaturesNativeHandler(v8::Handle<v8::Context> context)
+      : ObjectBackedNativeHandler(context) {
+    RouteFunction("GetAPIFeatures",
+        base::Bind(&TestFeaturesNativeHandler::GetAPIFeatures,
+                   base::Unretained(this)));
+  }
+
+ private:
+  v8::Handle<v8::Value> GetAPIFeatures(const v8::Arguments& args) {
+    // Read the JSON and write it back out to remove comments.
+    base::Value* value = base::JSONReader::Read(
+        ResourceBundle::GetSharedInstance().GetRawDataResource(
+            IDR_EXTENSION_API_FEATURES).as_string());

[not at google - send to devlin, 2013/05/03 04:58:14]

do you need to write it back to a string again? you could turn it into a
v8::Object and do it that way, v8valueconverter.

[cduvall, 2013/05/07 23:44:29]

Done.

+    std::string json_str;
+    base::JSONWriter::Write(value, &json_str);
+    return v8::String::New(json_str.c_str());
+  }
+};
+
 class SchemaRegistryNativeHandler : public ObjectBackedNativeHandler {
  public:
   SchemaRegistryNativeHandler(V8SchemaRegistry* registry,
                               v8::Handle<v8::Context> context)
       : ObjectBackedNativeHandler(context),
         registry_(registry) {
     RouteFunction("GetSchema",
         base::Bind(&SchemaRegistryNativeHandler::GetSchema,
                    base::Unretained(this)));
   }
@@ skipping 566 matching lines @@
 }
 
 void Dispatcher::RegisterSchemaGeneratedBindings(
     ModuleSystem* module_system,
     ChromeV8Context* context) {
   std::set<std::string> apis =
       ExtensionAPI::GetSharedInstance()->GetAllAPINames();
   for (std::set<std::string>::iterator it = apis.begin();
        it != apis.end(); ++it) {
     const std::string& api_name = *it;
-    if (!context->GetAvailabilityForContext(api_name).is_available())
+    if (!context->IsAnyFeatureAvailableToContext(api_name))
       continue;
 
     Feature* feature =
         BaseFeatureProvider::GetByName("api")->GetFeature(api_name);
     if (feature && feature->IsInternal())
       continue;
 
     std::vector<std::string> split;
     base::SplitString(api_name, '.', &split);
 
@@ skipping 294 matching lines @@
   module_system->RegisterNativeHandler("lazy_background_page",
       scoped_ptr<NativeHandler>(
           new LazyBackgroundPageNativeHandler(this, v8_context)));
   module_system->RegisterNativeHandler("logging",
       scoped_ptr<NativeHandler>(new LoggingNativeHandler(v8_context)));
   module_system->RegisterNativeHandler("schema_registry",
       scoped_ptr<NativeHandler>(
           new SchemaRegistryNativeHandler(v8_schema_registry(), v8_context)));
   module_system->RegisterNativeHandler("v8_context",
       scoped_ptr<NativeHandler>(new V8ContextNativeHandler(context, this)));
+  module_system->RegisterNativeHandler("test_features",
+      scoped_ptr<NativeHandler>(new TestFeaturesNativeHandler(v8_context)));
 
   int manifest_version = extension ? extension->manifest_version() : 1;
   bool send_request_disabled =
       (extension && Manifest::IsUnpackedLocation(extension->location()) &&
        BackgroundInfo::HasLazyBackgroundPage(extension));
   module_system->RegisterNativeHandler("process",
       scoped_ptr<NativeHandler>(new ProcessInfoNativeHandler(
           this, v8_context, context->GetExtensionID(),
           context->GetContextTypeDescription(),
           ChromeRenderProcessObserver::is_incognito_process(),
@@ skipping 399 matching lines @@
     std::string error_msg = base::StringPrintf(kMessage, function_name.c_str());
     v8::ThrowException(
         v8::Exception::Error(v8::String::New(error_msg.c_str())));
     return false;
   }
 
   return true;
 }
 
 }  // namespace extensions