Allow API functions and events to have entries in _api_features.json

chrome/common/extensions/api/extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/extension_api.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 391 matching lines @@
 void ExtensionAPI::RegisterSchema(const std::string& name,
                                   const base::StringPiece& source) {
   unloaded_schemas_[name] = source;
 }
 
 void ExtensionAPI::RegisterDependencyProvider(const std::string& name,
                                               FeatureProvider* provider) {
   dependency_providers_[name] = provider;
 }
 
+Feature::Availability ExtensionAPI::IsPartAvailableToContext(

[not at google - send to devlin, 2013/04/27 01:02:43]

this method should probably return a bool, since it's unclear what the or-ing
together of several availabilities is, whereas it's clear what or-ing several
bools are.

if you know what I mean...

[cduvall, 2013/05/01 02:51:47]

Done.

+    const std::string& api_name,
+    Feature::Context context,
+    const GURL& url) {
+  FeatureProviderMap::iterator provider = dependency_providers_.find("api");
+  CHECK(provider != dependency_providers_.end());
+  std::set<std::string> features = provider->second->GetAllFeatureNames();
+
+  // Check to see if there are any parts of this API that are allowed in this
+  // context.
+  for (std::set<std::string>::iterator i = features.begin();
+       i != features.end(); ++i) {
+    std::string feature_name = *i;

[not at google - send to devlin, 2013/04/27 01:02:43]

std::string&

[cduvall, 2013/05/01 02:51:47]

Done.

+    if (feature_name != api_name && feature_name.find(api_name) == 0) {

[not at google - send to devlin, 2013/04/27 01:02:43]

i'm worried that at some point we'll have API names that are legitimately
subsets of others. E.g. a hypothetical appFoo API, of which app is a prefix.

I.e. use string-split or feature_name.find(api_name + ".") or something.

[cduvall, 2013/05/01 02:51:47]

Done.

+      Feature::Availability availability =
+          IsAvailable(feature_name, NULL, context, url);
+      if (availability.is_available())
+        return availability;
+    }
+  }
+  return IsAvailable(api_name, NULL, context, url);
+}
+
 Feature::Availability ExtensionAPI::IsAvailable(const std::string& full_name,
                                                 const Extension* extension,
                                                 Feature::Context context,
                                                 const GURL& url) {
   std::string feature_type;
   std::string feature_name;
   SplitDependencyName(full_name, &feature_type, &feature_name);
 
   std::string child_name;
   std::string api_name = GetAPINameFromFullName(feature_name, &child_name);
@@ skipping 219 matching lines @@
   return extension->required_permission_set()->HasAnyAccessToAPI(name) ||
       extension->optional_permission_set()->HasAnyAccessToAPI(name);
 }
 
 bool ExtensionAPI::IsPrivilegedAPI(const std::string& name) {
   return completely_unprivileged_apis_.count(name) ||
       partially_unprivileged_apis_.count(name);
 }
 
 }  // namespace extensions