chrome/renderer/translate/translate_helper_browsertest.cc - Issue 14494004: Added the 'Translation Logs' tab to chrome://translate-internals/

Unified Diff: chrome/renderer/translate/translate_helper_browsertest.cc

Issue 14494004: Added the 'Translation Logs' tab to chrome://translate-internals/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (Rebasing) Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/translate/translate_helper_browsertest.cc

diff --git a/chrome/renderer/translate/translate_helper_browsertest.cc b/chrome/renderer/translate/translate_helper_browsertest.cc

index ecf202ef276167e3298cde1895a27dc9675ddafe..f3eb3a45ecd5bdd264179b40a76173ea0ca4928d 100644

--- a/chrome/renderer/translate/translate_helper_browsertest.cc

+++ b/chrome/renderer/translate/translate_helper_browsertest.cc

@@ -387,7 +387,7 @@ TEST_F(ChromeRenderViewTest, LanguageMetaTag) {

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Param params;

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("es", params.a);

+ EXPECT_EQ("es", params.a.adopted_language);

render_thread_->sink().ClearMessages();

// Makes sure we support multiple languages specified.

@@ -398,7 +398,7 @@ TEST_F(ChromeRenderViewTest, LanguageMetaTag) {

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("fr", params.a);

+ EXPECT_EQ("fr", params.a.adopted_language);

}

// Tests that the language meta tag works even with non-all-lower-case.

@@ -415,7 +415,7 @@ TEST_F(ChromeRenderViewTest, LanguageMetaTagCase) {

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Param params;

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("es", params.a);

+ EXPECT_EQ("es", params.a.adopted_language);

render_thread_->sink().ClearMessages();

// Makes sure we support multiple languages specified.

@@ -426,7 +426,7 @@ TEST_F(ChromeRenderViewTest, LanguageMetaTagCase) {

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("fr", params.a);

+ EXPECT_EQ("fr", params.a.adopted_language);

}

// Tests that the language meta tag is converted to Chrome standard of dashes

@@ -444,7 +444,7 @@ TEST_F(ChromeRenderViewTest, LanguageCommonMistakesAreCorrected) {

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Param params;

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("en-US", params.a);

+ EXPECT_EQ("en-US", params.a.adopted_language);

render_thread_->sink().ClearMessages();

}

@@ -458,7 +458,7 @@ TEST_F(ChromeRenderViewTest, BackToTranslatablePage) {

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Param params;

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("zh", params.a);

+ EXPECT_EQ("zh", params.a.adopted_language);

render_thread_->sink().ClearMessages();

LoadHTML("<html><head><meta http-equiv=\"content-language\" content=\"fr\">"

@@ -467,7 +467,7 @@ TEST_F(ChromeRenderViewTest, BackToTranslatablePage) {

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("fr", params.a);

+ EXPECT_EQ("fr", params.a.adopted_language);

render_thread_->sink().ClearMessages();

GoBack(GetMainFrame()->previousHistoryItem());

@@ -476,6 +476,6 @@ TEST_F(ChromeRenderViewTest, BackToTranslatablePage) {

ChromeViewHostMsg_TranslateLanguageDetermined::ID);

ASSERT_NE(static_cast<IPC::Message*>(NULL), message);

ChromeViewHostMsg_TranslateLanguageDetermined::Read(message, &params);

- EXPECT_EQ("zh", params.a);

+ EXPECT_EQ("zh", params.a.adopted_language);

render_thread_->sink().ClearMessages();

}

« no previous file with comments | « chrome/renderer/translate/translate_helper.cc ('k') | chrome/renderer/translate/translate_helper_unittest.cc » ('j') | no next file with comments »