Added the 'Translation Logs' tab to chrome://translate-internals/

chrome/renderer/translate/translate_helper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_H_
 #define CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 90 matching lines @@
   static void CorrectLanguageCodeTypo(std::string* code);
 
   // Convert language code to the one used in server supporting list.
   static void ConvertLanguageCodeSynonym(std::string* code);
 
   // Reset language code if the specified string is apparently invalid.
   static void ResetInvalidLanguageCode(std::string* code);
 
   // Determine content page language from Content-Language code and contents.
   static std::string DeterminePageLanguage(const std::string& code,
-                                           const string16& contents);
+                                           const string16& contents,
+                                           std::string* cld_language = NULL,

[MAD, 2013/05/07 19:49:05]

We don't use default value for function arguments in Chrome.

[hajimehoshi, 2013/05/08 04:06:17]

Done.  Added a test to translate_helper_unittest.cc to check these returned
values.

On 2013/05/07 19:49:05, MAD wrote:

+                                           bool* is_cld_reliable = NULL);
 
   // Returns whether the page associated with |document| is a candidate for
   // translation.  Some pages can explictly specify (via a meta-tag) that they
   // should not be translated.
   static bool IsPageTranslatable(WebKit::WebDocument* document);
 
 #if defined(ENABLE_LANGUAGE_DETECTION)
   // Returns the ISO 639_1 language code of the specified |text|, or 'unknown'
   // if it failed.
-  static std::string DetermineTextLanguage(const string16& text);
+  // |is_cld_reliable| is optional. This will be set as true is CLD saids the

[MAD, 2013/05/07 19:49:05]

is CLD saids -> if CLD says.

[hajimehoshi, 2013/05/08 04:06:17]

Done.

+  // detection is reliable, otherwise not.

[MAD, 2013/05/07 19:49:05]

No need for otherwise in comments when it's bool.

[hajimehoshi, 2013/05/08 04:06:17]

Done.

+  static std::string DetermineTextLanguage(const string16& text,
+                                           bool* is_cld_reliable = NULL);

[MAD, 2013/05/07 19:49:05]

Again.

[hajimehoshi, 2013/05/08 04:06:17]

Done.

 #endif
 
   // RenderViewObserver implementation.
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // Cancels any translation that is currently being performed.  This does not
   // revert existing translations.
   void CancelPendingTranslation();
 
   // Checks if the current running page translation is finished or errored and
@@ skipping 19 matching lines @@
   std::string source_lang_;
   std::string target_lang_;
 
   // Method factory used to make calls to TranslatePageImpl.
   base::WeakPtrFactory<TranslateHelper> weak_method_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TranslateHelper);
 };
 
 #endif  // CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_H_