Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: test/cctest/profiler-extension.cc

Issue 1449393002: Remove deprecated functions the smaller half of the remaing tests (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/print-extension.cc ('k') | test/cctest/test-assembler-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 // 27 //
28 // Tests of profiles generator and utilities. 28 // Tests of profiles generator and utilities.
29 29
30 // TODO(jochen): Remove this after the setting is turned on globally.
31 #define V8_IMMINENT_DEPRECATION_WARNINGS
32
30 #include "src/base/logging.h" 33 #include "src/base/logging.h"
31 #include "test/cctest/profiler-extension.h" 34 #include "test/cctest/profiler-extension.h"
32 35
33 namespace v8 { 36 namespace v8 {
34 namespace internal { 37 namespace internal {
35 38
36 39
37 v8::CpuProfile* ProfilerExtension::last_profile = NULL; 40 v8::CpuProfile* ProfilerExtension::last_profile = NULL;
38 const char* ProfilerExtension::kSource = 41 const char* ProfilerExtension::kSource =
39 "native function startProfiling();" 42 "native function startProfiling();"
40 "native function stopProfiling();"; 43 "native function stopProfiling();";
41 44
42 v8::Handle<v8::FunctionTemplate> ProfilerExtension::GetNativeFunctionTemplate( 45 v8::Local<v8::FunctionTemplate> ProfilerExtension::GetNativeFunctionTemplate(
43 v8::Isolate* isolate, v8::Handle<v8::String> name) { 46 v8::Isolate* isolate, v8::Local<v8::String> name) {
44 if (name->Equals(v8::String::NewFromUtf8(isolate, "startProfiling"))) { 47 v8::Local<v8::Context> context = isolate->GetCurrentContext();
48 if (name->Equals(context, v8::String::NewFromUtf8(isolate, "startProfiling",
49 v8::NewStringType::kNormal)
50 .ToLocalChecked())
51 .FromJust()) {
45 return v8::FunctionTemplate::New(isolate, 52 return v8::FunctionTemplate::New(isolate,
46 ProfilerExtension::StartProfiling); 53 ProfilerExtension::StartProfiling);
47 } else if (name->Equals(v8::String::NewFromUtf8(isolate, "stopProfiling"))) { 54 } else if (name->Equals(context,
55 v8::String::NewFromUtf8(isolate, "stopProfiling",
56 v8::NewStringType::kNormal)
57 .ToLocalChecked())
58 .FromJust()) {
48 return v8::FunctionTemplate::New(isolate, 59 return v8::FunctionTemplate::New(isolate,
49 ProfilerExtension::StopProfiling); 60 ProfilerExtension::StopProfiling);
50 } else { 61 } else {
51 CHECK(false); 62 CHECK(false);
52 return v8::Handle<v8::FunctionTemplate>(); 63 return v8::Local<v8::FunctionTemplate>();
53 } 64 }
54 } 65 }
55 66
56 67
57 void ProfilerExtension::StartProfiling( 68 void ProfilerExtension::StartProfiling(
58 const v8::FunctionCallbackInfo<v8::Value>& args) { 69 const v8::FunctionCallbackInfo<v8::Value>& args) {
59 last_profile = NULL; 70 last_profile = NULL;
60 v8::CpuProfiler* cpu_profiler = args.GetIsolate()->GetCpuProfiler(); 71 v8::CpuProfiler* cpu_profiler = args.GetIsolate()->GetCpuProfiler();
61 cpu_profiler->StartProfiling((args.Length() > 0) 72 cpu_profiler->StartProfiling((args.Length() > 0)
62 ? args[0].As<v8::String>() 73 ? args[0].As<v8::String>()
63 : v8::String::Empty(args.GetIsolate())); 74 : v8::String::Empty(args.GetIsolate()));
64 } 75 }
65 76
66 77
67 void ProfilerExtension::StopProfiling( 78 void ProfilerExtension::StopProfiling(
68 const v8::FunctionCallbackInfo<v8::Value>& args) { 79 const v8::FunctionCallbackInfo<v8::Value>& args) {
69 v8::CpuProfiler* cpu_profiler = args.GetIsolate()->GetCpuProfiler(); 80 v8::CpuProfiler* cpu_profiler = args.GetIsolate()->GetCpuProfiler();
70 last_profile = cpu_profiler->StopProfiling((args.Length() > 0) 81 last_profile = cpu_profiler->StopProfiling((args.Length() > 0)
71 ? args[0].As<v8::String>() 82 ? args[0].As<v8::String>()
72 : v8::String::Empty(args.GetIsolate())); 83 : v8::String::Empty(args.GetIsolate()));
73 } 84 }
74 85
75 } // namespace internal 86 } // namespace internal
76 } // namespace v8 87 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/print-extension.cc ('k') | test/cctest/test-assembler-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698