Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1449323004:
Remove ScopedVector from message_pump_perftest (Closed)
|
Created:
5 years, 1 month ago by Olli Raula Modified:
5 years, 1 month ago CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ScopedVector from message_pump_perftest
BUG=554289
Committed: https://crrev.com/00971ff41cef8305357dd2fcc4a06a82043b2187
Cr-Commit-Position: refs/heads/master@{#360931}
Patch Set 1 #Patch Set 2 : git cl try #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Remove ScopedVector from chunked_upload_data_stream BUG=554289 ========== to ========== Remove ScopedVector from chunked_upload_data_stream BUG=554289 ==========
olli.raula@intel.com changed reviewers: + eroman@chromium.org
Could you review
lgtm
The CQ bit was checked by olli.raula@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449323004/20001
The CQ bit was unchecked by olli.raula@intel.com
Description was changed from ========== Remove ScopedVector from chunked_upload_data_stream BUG=554289 ========== to ========== Remove ScopedVector from message_pump_perftest BUG=554289 ==========
The CQ bit was checked by olli.raula@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449323004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
olli.raula@intel.com changed reviewers: + thestig@chromium.org
Thestig, could you check this. I will upload that first patch again in separated cl.
The CQ bit was checked by thestig@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449323004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/00971ff41cef8305357dd2fcc4a06a82043b2187 Cr-Commit-Position: refs/heads/master@{#360931} |
