Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1449243002: Switch dominator algorithm from [1] to [2]. (Closed)

Created:
5 years, 1 month ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch dominator algorithm from [1] to [2]. [1] has worse upper bound complexity than [2] but has lower overhead. With [1] dart2js heaps would converge in ~10 iterations, but with analyzer heaps would take ~10k iterations. This reduces the time to analyze the final heap of the analyzer analyzing dart2js from ~30 minutes to 26 seconds. Increases peak memory usage by 21N bytes plus O(2N) words. [1] "A Simple, Fast Dominance Algorithm." Keith D. Cooper, Timothy J. Harvey, and Ken Kennedy. [2] "A Fast Algorithm for Finding Dominators in a Flowgraph." T. Lengauer and R. E. Tarjan. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5eb3bccaf1f61e2993b8909a27a9256b96cb8e88

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -99 lines) Patch
M runtime/observatory/lib/object_graph.dart View 7 chunks +226 lines, -99 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-17 00:42:37 UTC) #2
Cutch
LGTM after removing the two completely commented out functions. https://codereview.chromium.org/1449243002/diff/1/runtime/observatory/lib/object_graph.dart File runtime/observatory/lib/object_graph.dart (right): https://codereview.chromium.org/1449243002/diff/1/runtime/observatory/lib/object_graph.dart#newcode648 runtime/observatory/lib/object_graph.dart:648: ...
5 years, 1 month ago (2015-11-17 18:40:09 UTC) #3
rmacnak
https://codereview.chromium.org/1449243002/diff/1/runtime/observatory/lib/object_graph.dart File runtime/observatory/lib/object_graph.dart (right): https://codereview.chromium.org/1449243002/diff/1/runtime/observatory/lib/object_graph.dart#newcode648 runtime/observatory/lib/object_graph.dart:648: // } On 2015/11/17 18:40:09, Cutch wrote: > Remove ...
5 years, 1 month ago (2015-11-17 19:20:24 UTC) #4
rmacnak
5 years, 1 month ago (2015-11-17 19:20:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5eb3bccaf1f61e2993b8909a27a9256b96cb8e88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698