Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 1449223002: GN: Use NaCl's newlib objdump for PNaCl (Closed)

Created:
5 years, 1 month ago by Petr Hosek
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Use NaCl's newlib objdump for PNaCl PNaCl doesn't provide objdump, so use NaCl newlib version when generating nmf files for PNaCl since the create_nmf.py script requires objdump to be set. BUG=462791 Committed: https://crrev.com/102f32212c2e08281d38f59a802377934318680e Cr-Commit-Position: refs/heads/master@{#359970}

Patch Set 1 #

Patch Set 2 : Add TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/config/nacl/rules.gni View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Petr Hosek
5 years, 1 month ago (2015-11-17 00:21:39 UTC) #2
Roland McGrath
LGTM if you add a comment, maybe with a TODO or a bug filed nacl-side ...
5 years, 1 month ago (2015-11-17 00:25:09 UTC) #3
Dirk Pranke
lgtm w/ mcgrathr's comment addressed.
5 years, 1 month ago (2015-11-17 00:31:59 UTC) #4
Petr Hosek
Done.
5 years, 1 month ago (2015-11-17 00:34:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449223002/20001
5 years, 1 month ago (2015-11-17 00:50:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 01:44:54 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 01:46:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/102f32212c2e08281d38f59a802377934318680e
Cr-Commit-Position: refs/heads/master@{#359970}

Powered by Google App Engine
This is Rietveld 408576698