Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Issue 1449213002: Parse flex/flex-flow shorthands in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 1 month ago by rwlbuis
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse flex/flex-flow shorthands in CSSPropertyParser with CSSParserTokens Move flex/flex-flow shorthands property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. BUG=499780 Committed: https://crrev.com/3dfdc7f70d6b84593e1983a87c9584a2d332e96e Cr-Commit-Position: refs/heads/master@{#360667}

Patch Set 1 #

Patch Set 2 : Fix compile errors #

Patch Set 3 : Add flex-flow shorthand #

Patch Set 4 : Patch for review #

Total comments: 4

Patch Set 5 : Rebase #

Patch Set 6 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -73 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 5 4 chunks +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 3 4 5 4 chunks +5 lines, -72 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
rwlbuis
PTAL.
5 years, 1 month ago (2015-11-17 20:06:03 UTC) #3
Timothy Loh
lgtm https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode2402 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2402: flexGrow = flexShrink = 0; Isn't this against ...
5 years, 1 month ago (2015-11-19 05:36:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449213002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449213002/120001
5 years, 1 month ago (2015-11-19 17:05:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/98418)
5 years, 1 month ago (2015-11-19 17:26:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449213002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449213002/120001
5 years, 1 month ago (2015-11-19 18:48:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449213002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449213002/120001
5 years, 1 month ago (2015-11-19 21:17:13 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 1 month ago (2015-11-19 21:26:16 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 21:28:00 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3dfdc7f70d6b84593e1983a87c9584a2d332e96e
Cr-Commit-Position: refs/heads/master@{#360667}

Powered by Google App Engine
This is Rietveld 408576698