Parse flex/flex-flow shorthands in CSSPropertyParser with CSSParserTokens

Parse flex/flex-flow shorthands in CSSPropertyParser with CSSParserTokens

Move flex/flex-flow shorthands property handling from LegacyCSSPropertyParser
into CSSPropertyParser. Also move its related longhands.

BUG=499780
Committed: https://crrev.com/3dfdc7f70d6b84593e1983a87c9584a2d332e96e
Cr-Commit-Position: refs/heads/master@{#360667}

[rwlbuis, 2015-11-17 18:41:10]

Description was changed from

==========
Flex wip

BUG=
==========

to

==========
Parse flex/flex-flow shorthands in CSSPropertyParser with CSSParserTokens

Move flex/flex-flow shorthands property handling from LegacyCSSPropertyParser
into CSSPropertyParser. Also move its related longhands.

BUG=499780
==========

[rwlbuis, 2015-11-17 20:06:02]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2015-11-17 20:06:03]

PTAL.

[rwlbuis, 2015-11-18 03:40:03]

Patchset #5 (id:80001) has been deleted

[Timothy Loh, 2015-11-19 05:36:59]

lgtm

https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2402: flexGrow =
flexShrink = 0;
Isn't this against the style guide? At least I never see it around, let's just
put them on separate lines.

https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2407: while
(!m_range.atEnd() && index++ < 3) {
I'd prefer a regular for loop here. I got a bit confused by the index==2 check
at the bottom (I thought it meant the third value). Feel free to change or leave
it as is depending on what you prefer.

https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2423: if
(!flexBasis)
Better to just write "else"

https://codereview.chromium.org/1449213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:2425: if
(flexBasis && index == 2 && !m_range.atEnd())
I guess this doesn't need to check flexBasis, I think it's a tiny bit clearer
without it.

[rwlbuis, 2015-11-19 17:04:59]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-11-19 17:04:59]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1449213002/#ps120001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-11-19 17:05:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449213002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449213002/120001

[commit-bot: I haz the power, 2015-11-19 17:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 17:26:26]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[rwlbuis, 2015-11-19 18:47:10]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-11-19 18:48:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449213002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449213002/120001

[rwlbuis, 2015-11-19 19:54:03]

Patchset #7 (id:140001) has been deleted

[rwlbuis, 2015-11-19 21:16:31]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2015-11-19 21:16:31]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1449213002/#ps120001
(title: "Patch for landing")

[commit-bot: I haz the power, 2015-11-19 21:17:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449213002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449213002/120001

[commit-bot: I haz the power, 2015-11-19 21:26:16]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-11-19 21:28:00]

Patchset 6 (id:??) landed as
https://crrev.com/3dfdc7f70d6b84593e1983a87c9584a2d332e96e
Cr-Commit-Position: refs/heads/master@{#360667}