Change the cast in base::Location::Hash to uintptr_t.

Change the cast in base::Location::Hash to uintptr_t.

This allows the appropriate HashPair function to be called depending on whether this is a 32 or 64-bit system.

On a 32-bit platform, using HashInts64 on 32-bit values doesn't buy us any
additional entropy (*hand-wavey*) compared to using HashInts32. It is more
expensive, generating an extra 4 64-bit multiplies, each results in a function
call (to _allmul) on Windows-32.

Committed: https://crrev.com/37d5552647f58f20069c485cf4203fe05839921b
Cr-Commit-Position: refs/heads/master@{#362819}

[Anand Mistry (off Chromium), 2015-11-16 22:48:30]

amistry@chromium.org changed reviewers:
+ danakj@chromium.org

[Anand Mistry (off Chromium), 2015-11-16 22:48:30]

Split from https://codereview.chromium.org/1445013002/

[Anand Mistry (off Chromium), 2015-12-02 09:30:51]

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 09:31:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449173002/1

[commit-bot: I haz the power, 2015-12-02 12:08:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 12:08:33]

Dry run: This issue passed the CQ dry run.

[Anand Mistry (off Chromium), 2015-12-02 20:02:26]

danakj: WDYT?

[danakj, 2015-12-02 20:49:41]

https://codereview.chromium.org/1449173002/diff/1/base/location.h
File base/location.h (left):

https://codereview.chromium.org/1449173002/diff/1/base/location.h#oldcode63
base/location.h:63: // file name pointer to a uintptr_t causes a compiler error
for some
No more compiler errors? Cool. LGTM

[Anand Mistry (off Chromium), 2015-12-02 23:13:36]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2015-12-02 23:15:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449173002/1

[commit-bot: I haz the power, 2015-12-02 23:31:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-02 23:32:00]

Description was changed from

==========
Change the cast in base::Location::Hash to uintptr_t.

This allows the appropriate HashPair function to be called depending on whether
this is a 32 or 64-bit system.

On a 32-bit platform, using HashInts64 on 32-bit values doesn't buy us any
additional entropy (*hand-wavey*) compared to using HashInts32. It is more
expensive, generating an extra 4 64-bit multiplies, each results in a function
call (to _allmul) on Windows-32.
==========

to

==========
Change the cast in base::Location::Hash to uintptr_t.

This allows the appropriate HashPair function to be called depending on whether
this is a 32 or 64-bit system.

On a 32-bit platform, using HashInts64 on 32-bit values doesn't buy us any
additional entropy (*hand-wavey*) compared to using HashInts32. It is more
expensive, generating an extra 4 64-bit multiplies, each results in a function
call (to _allmul) on Windows-32.

Committed: https://crrev.com/37d5552647f58f20069c485cf4203fe05839921b
Cr-Commit-Position: refs/heads/master@{#362819}
==========

[commit-bot: I haz the power, 2015-12-02 23:32:01]

Patchset 1 (id:??) landed as
https://crrev.com/37d5552647f58f20069c485cf4203fe05839921b
Cr-Commit-Position: refs/heads/master@{#362819}