- Include sources in gen_snapshot and dart_no_snapshot to allow

- Include sources in gen_snapshot and dart_no_snapshot to allow
  creating full snapshots without having a full Dart SDK checkout.

BUG=
R=asiva@google.com, chinmaygarde@google.com

Committed: https://github.com/dart-lang/sdk/commit/d97c7bdbde9165d338f67bb2e03f15f58d1a7741

[Ivan Posva, 2015-11-17 18:59:56]

iposva@google.com changed reviewers:
+ asiva@google.com, chinmaygarde@google.com

[Chinmay, 2015-11-17 19:16:56]

https://codereview.chromium.org/1449163003/diff/1/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/1449163003/diff/1/runtime/vm/bootstrap.cc#new...
runtime/vm/bootstrap.cc:155: return String::null();
Should the file handle be closed in this case?

[Ivan Posva, 2015-11-17 19:29:17]

Thanks! -ip

https://codereview.chromium.org/1449163003/diff/1/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/1449163003/diff/1/runtime/vm/bootstrap.cc#new...
runtime/vm/bootstrap.cc:155: return String::null();
On 2015/11/17 19:16:56, Chinmay wrote:
> Should the file handle be closed in this case?

Done.

[Chinmay, 2015-11-17 19:30:01]

On 2015/11/17 at 19:29:17, iposva wrote:
> Thanks! -ip
> 
> https://codereview.chromium.org/1449163003/diff/1/runtime/vm/bootstrap.cc
> File runtime/vm/bootstrap.cc (right):
> 
>
https://codereview.chromium.org/1449163003/diff/1/runtime/vm/bootstrap.cc#new...
> runtime/vm/bootstrap.cc:155: return String::null();
> On 2015/11/17 19:16:56, Chinmay wrote:
> > Should the file handle be closed in this case?
> 
> Done.

lgtm (not an owner though)

[siva, 2015-11-17 19:37:56]

lgtm

https://codereview.chromium.org/1449163003/diff/20001/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/1449163003/diff/20001/runtime/vm/bootstrap.cc...
runtime/vm/bootstrap.cc:158: ASSERT(utf8_array != NULL);
This assert can move down to the else block as it is valid in both cases now.

[Ivan Posva, 2015-11-17 22:50:26]

Thanks!

-Ivan

https://codereview.chromium.org/1449163003/diff/20001/runtime/vm/bootstrap.cc
File runtime/vm/bootstrap.cc (right):

https://codereview.chromium.org/1449163003/diff/20001/runtime/vm/bootstrap.cc...
runtime/vm/bootstrap.cc:158: ASSERT(utf8_array != NULL);
On 2015/11/17 19:37:55, siva wrote:
> This assert can move down to the else block as it is valid in both cases now.

Simplified the whole logic around here. Did not like it too much with the
multiple jumps out in the middle.

[Ivan Posva, 2015-11-17 22:58:13]

Committed patchset #3 (id:40001) manually as
d97c7bdbde9165d338f67bb2e03f15f58d1a7741 (presubmit successful).