Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1449143002: DevTools: remove Object.observe usage, it is being deprecated. (Closed)

Created:
5 years, 1 month ago by pfeldman
Modified:
5 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove Object.observe usage, it is being deprecated. BUG=552101 Committed: https://crrev.com/b327bcdb1c84c335e0acddb606ac85f34a07ea70 Cr-Commit-Position: refs/heads/master@{#360003}

Patch Set 1 #

Total comments: 1

Patch Set 2 : removeAll added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -53 lines) Patch
M third_party/WebKit/Source/devtools/front_end/common/Settings.js View 1 9 chunks +96 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +2 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
5 years, 1 month ago (2015-11-16 22:22:45 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1449143002/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/1449143002/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode93 third_party/WebKit/Source/devtools/front_end/main/Main.js:93: WebInspector.settings = new WebInspector.Settings(new WebInspector.SettingsStorage(prefs, InspectorFrontendHost.setPreference, InspectorFrontendHost.removePreference)); Pass ...
5 years, 1 month ago (2015-11-16 22:43:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449143002/20001
5 years, 1 month ago (2015-11-16 23:40:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/141472)
5 years, 1 month ago (2015-11-17 00:22:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449143002/20001
5 years, 1 month ago (2015-11-17 03:44:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 04:52:45 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 04:53:40 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b327bcdb1c84c335e0acddb606ac85f34a07ea70
Cr-Commit-Position: refs/heads/master@{#360003}

Powered by Google App Engine
This is Rietveld 408576698