Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: content/browser/compositor/gpu_process_transport_factory.cc

Issue 1449133002: TaskGraphRunner refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/gpu_process_transport_factory.cc
diff --git a/content/browser/compositor/gpu_process_transport_factory.cc b/content/browser/compositor/gpu_process_transport_factory.cc
index 45719ac433338ce2b73b30e8be851e467a1265aa..1ae2b118128e3e62d2989d0c209b783e9a9012b0 100644
--- a/content/browser/compositor/gpu_process_transport_factory.cc
+++ b/content/browser/compositor/gpu_process_transport_factory.cc
@@ -17,6 +17,7 @@
#include "cc/base/histograms.h"
#include "cc/output/compositor_frame.h"
#include "cc/output/output_surface.h"
+#include "cc/raster/single_thread_task_graph_runner.h"
#include "cc/raster/task_graph_runner.h"
#include "cc/surfaces/onscreen_display_client.h"
#include "cc/surfaces/surface_display_output_surface.h"
@@ -82,24 +83,6 @@ using gpu::gles2::GLES2Interface;
static const int kNumRetriesBeforeSoftwareFallback = 4;
namespace content {
-namespace {
-
-class RasterThread : public base::SimpleThread {
- public:
- RasterThread(cc::TaskGraphRunner* task_graph_runner)
- : base::SimpleThread("CompositorTileWorker1"),
- task_graph_runner_(task_graph_runner) {}
-
- // Overridden from base::SimpleThread:
- void Run() override { task_graph_runner_->Run(); }
-
- private:
- cc::TaskGraphRunner* task_graph_runner_;
-
- DISALLOW_COPY_AND_ASSIGN(RasterThread);
-};
-
-} // namespace
struct GpuProcessTransportFactory::PerCompositorData {
int surface_id;
@@ -112,7 +95,7 @@ struct GpuProcessTransportFactory::PerCompositorData {
GpuProcessTransportFactory::GpuProcessTransportFactory()
: next_surface_id_namespace_(1u),
- task_graph_runner_(new cc::TaskGraphRunner),
+ task_graph_runner_(new cc::SingleThreadTaskGraphRunner),
callback_factory_(this) {
ui::Layer::InitializeUILayerSettings();
cc::SetClientNameForMetrics("Browser");
@@ -120,8 +103,8 @@ GpuProcessTransportFactory::GpuProcessTransportFactory()
if (UseSurfacesEnabled())
surface_manager_ = make_scoped_ptr(new cc::SurfaceManager);
- raster_thread_.reset(new RasterThread(task_graph_runner_.get()));
- raster_thread_->Start();
+ task_graph_runner_->Start("CompositorTileWorker1",
+ base::SimpleThread::Options());
#if defined(OS_WIN)
software_backing_.reset(new OutputDeviceBacking);
#endif
@@ -134,8 +117,6 @@ GpuProcessTransportFactory::~GpuProcessTransportFactory() {
callback_factory_.InvalidateWeakPtrs();
task_graph_runner_->Shutdown();
- if (raster_thread_)
- raster_thread_->Join();
}
scoped_ptr<WebGraphicsContext3DCommandBufferImpl>
« no previous file with comments | « content/browser/compositor/gpu_process_transport_factory.h ('k') | content/browser/renderer_host/compositor_impl_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698