Issue 144913003: Reland (and fix) "Add hydrogen support for ArrayPop, and remove the handwritten call stubs."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144913003: Reland (and fix) "Add hydrogen support for ArrayPop, and remove the handwritten call stubs." (Closed)

Created:
6 years, 11 months ago by Toon Verwaest

Modified:
6 years, 11 months ago

Reviewers:
mvstanton, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reland (and fix) "Add hydrogen support for ArrayPop, and remove the handwritten call stubs." BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18749

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -298 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+0 lines, -73 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+47 lines, -0 lines	1 comment	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+0 lines, -70 lines	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	src/stub-cache.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+0 lines, -71 lines	0 comments	Download
A +	test/mjsunit/regress/regress-array-pop-deopt.js	View	1 chunk	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

Committed patchset #1 manually as r18749 (presubmit successful).

6 years, 11 months ago (2014-01-22 13:23:08 UTC) #3

Jakob Kummerow

6 years, 11 months ago (2014-01-24 08:34:45 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/144913003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/144913003/diff/1/src/hydrogen.cc#newcode7660
src/hydrogen.cc:7660: Add<HSimulate>(expr->id(), REMOVABLE_SIMULATE);
This line causes a NULL deref every time it is executed, because current_block
== 0 at this point. I've reverted this change in r18805, please don't reland
without adding a testcase that covers this codepath.

Expand Messages | Collapse Messages