use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in ports/SkMemory_mozalloc.cpp

use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in ports/SkMemory_mozalloc.cpp

BUG=skia:4560
Committed: https://skia.googlesource.com/skia/+/b8b479b29d24f45a25dca74752ff6ed653e60ba9

[lsalzman1, 2015-11-16 21:50:40]

Description was changed from

==========
use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in
ports/SkMemory_mozalloc.cpp

BUG=skia:
==========

to

==========
use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in
ports/SkMemory_mozalloc.cpp

BUG=skia:
==========

[lsalzman1, 2015-11-16 21:50:41]

lsalzman@mozilla.com changed reviewers:
+ mtklein@google.com

[lsalzman1, 2015-11-16 21:51:36]

Re: https://code.google.com/p/skia/issues/detail?id=4560

[mtklein, 2015-11-16 22:08:00]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-11-16 22:08:00]

lgtm

[commit-bot: I haz the power, 2015-11-16 22:08:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449093002/1

[commit-bot: I haz the power, 2015-11-16 22:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 22:08:08]

The author lsalzman@mozilla.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[mtklein, 2015-11-16 22:41:33]

Description was changed from

==========
use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in
ports/SkMemory_mozalloc.cpp

BUG=skia:
==========

to

==========
use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in
ports/SkMemory_mozalloc.cpp

BUG=skia:4560
==========

[lsalzman1, 2015-11-23 17:14:00]

How to land this now? Docs say since I'm not a committer one of the Skia team
just has to pick this up...

[mtklein, 2015-11-23 17:15:31]

On 2015/11/16 at 22:08:08, commit-bot wrote:
> The author lsalzman@mozilla.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

Gotta sign the CLA before the bots will let us land this.
I'm a little surprised mozilla.com's not pre-signed for the whole domain.

[lsalzman1, 2015-11-23 17:20:04]

On 2015/11/23 17:15:31, mtklein wrote:
> On 2015/11/16 at 22:08:08, commit-bot wrote:
> > The author mailto:lsalzman@mozilla.com has not signed Google Contributor
License
> Agreement. Please visit https://cla.developers.google.com to sign and manage
> CLA.
> 
> Gotta sign the CLA before the bots will let us land this.
> I'm a little surprised mozilla.com's not pre-signed for the whole domain.

I signed and filled out an individual CLA for myself at least as of Nov 16, so
that should already be taken care of. When I visit the site again it claims I
have one on file already.

[mtklein, 2015-11-23 17:53:05]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-11-23 17:53:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449093002/1

[commit-bot: I haz the power, 2015-11-23 17:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 17:54:28]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2015-11-23 17:58:51]

On 2015/11/23 at 17:54:28, commit-bot wrote:
> Try jobs failed on following builders:
>   skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

Looks like you need to add yourself to AUTHORS too:

"The email lsalzman@mozilla.com is not in Skia's AUTHORS file."

[lsalzman1, 2015-11-23 18:00:16]

In the same patch as this one?

[mtklein, 2015-11-23 18:01:53]

On 2015/11/23 at 18:00:16, lsalzman wrote:
> In the same patch as this one?

Yep.

[lsalzman1, 2015-11-23 18:07:22]

On 2015/11/23 18:01:53, mtklein wrote:
> On 2015/11/23 at 18:00:16, lsalzman wrote:
> > In the same patch as this one?
> 
> Yep.

Done

[mtklein, 2015-11-23 18:16:33]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-11-23 18:16:33]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1449093002/#ps20001
(title: "use malloc/calloc/free instead of moz_malloc/moz_calloc/moz_free in
ports/SkMemory_mozalloc.cpp")

[commit-bot: I haz the power, 2015-11-23 18:16:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1449093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1449093002/20001

[commit-bot: I haz the power, 2015-11-23 18:30:18]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8b479b29d24f45a25dca74752ff6ed653e60ba9