Issue 1449053004: pkg/js: moved example code to https://github.com/google/chartjs.dart/

Issue 1449053004: pkg/js: moved example code to https://github.com/google/chartjs.dart/ (Closed)

Created:
5 years, 1 month ago by kevmoo

Modified:
5 years, 1 month ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

pkg/js: moved example code to https://github.com/google/chartjs.dart/ R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/87fc010974053f178600e6cdcba285341a10d4f9

Patch Set 2 : nits #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -160 lines)			Patch
M	pkg/js/CHANGELOG.md	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/js/README.md	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/js/example/README.md	View		1 chunk	+1 line, -14 lines	0 comments	Download
D	pkg/js/example/chart.dart	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	pkg/js/example/chart_js_example.dart	View		1 chunk	+0 lines, -67 lines	0 comments	Download
D	pkg/js/example/index.html	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	pkg/js/pubspec.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

lgtm https://codereview.chromium.org/1449053004/diff/1/pkg/js/README.md File pkg/js/README.md (right): https://codereview.chromium.org/1449053004/diff/1/pkg/js/README.md#newcode23 pkg/js/README.md:23: See the [Chart.js Dart API](https://github.com/google/chartjs.dart/) for a usage ...

5 years, 1 month ago (2015-11-17 19:04:50 UTC) #3

kevmoo

https://codereview.chromium.org/1449053004/diff/1/pkg/js/README.md File pkg/js/README.md (right): https://codereview.chromium.org/1449053004/diff/1/pkg/js/README.md#newcode23 pkg/js/README.md:23: See the [Chart.js Dart API](https://github.com/google/chartjs.dart/) for a usage example. ...

5 years, 1 month ago (2015-11-17 19:10:00 UTC) #4

kevmoo

5 years, 1 month ago (2015-11-17 19:10:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
87fc010974053f178600e6cdcba285341a10d4f9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages