Issue 1448993002: Switch ddc to use @JS instead of @JSName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1448993002: Switch ddc to use @JS instead of @JSName (Closed)

Created:
5 years, 1 month ago by Jacob

Modified:
5 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Switch ddc to use @JS instead of @JSName. Also update dart:js to support new public methods added for 1.13 BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/72890d156518eaf603b7a94abdf1229add80ff3f

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -75 lines)			Patch
M	lib/runtime/dart/_js_helper.js	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	lib/runtime/dart/js.js	View	2 chunks	+27 lines, -0 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/src/codegen/js_interop.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/codegen/expect/dom/dom.js	View	2 chunks	+0 lines, -10 lines	0 comments	Download
A	test/codegen/expect/js/js.js	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	test/codegen/expect/js/js.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/codegen/expect/sunflower/dom.js	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	test/codegen/expect/sunflower/sunflower.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/codegen/sunflower/dom.dart	View	8 chunks	+20 lines, -26 lines	0 comments	Download
M	tool/input_sdk/lib/js/dart2js/js_dart2js.dart	View	2 chunks	+43 lines, -1 line	0 comments	Download
M	tool/input_sdk/private/annotations.dart	View	1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 4 (1 generated)

Jacob

Also update dart:js to support new public methods added for 1.13 There are some good ...

5 years, 1 month ago (2015-11-16 17:54:09 UTC) #2

Jacob

5 years, 1 month ago (2015-11-16 20:55:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
72890d156518eaf603b7a94abdf1229add80ff3f (presubmit successful).