Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1448983002: Actually mark list accounts as stale while they're being fetched. (Closed)

Created:
5 years, 1 month ago by bzanotti
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Actually mark list accounts as stale while they're being fetched. GCMS::OnCookieChanged needs to always mark the list accounts as stale, even when they're being fetched. Otherwise, a call to GCMS::ListAccounts could return an invalid list if called right after GCMS::OnCookieChanged. BUG=558367 Committed: https://crrev.com/383bb87ce3b08ac2018b327585bcc623efb2e10e Cr-Commit-Position: refs/heads/master@{#361312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M components/signin/core/browser/gaia_cookie_manager_service.cc View 2 chunks +1 line, -2 lines 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
bzanotti
Please take a look.
5 years, 1 month ago (2015-11-16 17:41:42 UTC) #2
bzanotti
Friendly ping. :)
5 years, 1 month ago (2015-11-23 09:28:56 UTC) #5
Roger Tawa OOO till Jul 10th
lgtm Sorry for delay.
5 years, 1 month ago (2015-11-23 19:58:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448983002/1
5 years ago (2015-11-24 09:49:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 10:57:13 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 10:58:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/383bb87ce3b08ac2018b327585bcc623efb2e10e
Cr-Commit-Position: refs/heads/master@{#361312}

Powered by Google App Engine
This is Rietveld 408576698