Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/js/proxy.js

Issue 1448933002: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/promise.js ('k') | src/js/regexp.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/proxy.js
diff --git a/src/js/proxy.js b/src/js/proxy.js
index 950ac6b57e7e6ce1c855a4a1027acd560c46fb20..3885e408add350acff7d74276a48a28f7eb8cb5c 100644
--- a/src/js/proxy.js
+++ b/src/js/proxy.js
@@ -28,9 +28,7 @@ function ProxyCreate(target, handler) {
if (!%_IsConstructCall()) {
throw MakeTypeError(kConstructorNotFunction, "Proxy");
}
- // TODO(cbruni): Get the construct call right, this is just a prelimiary
- // version to get started with tests.
- return %CreateJSProxy(this, target, handler);
+ return %CreateJSProxy(target, handler);
}
function ProxyCreateFunction(handler, callTrap, constructTrap) {
@@ -183,14 +181,12 @@ function ProxyEnumerate(proxy) {
//-------------------------------------------------------------------
%SetCode(GlobalProxy, ProxyCreate);
-%FunctionSetPrototype(GlobalProxy, new GlobalObject());
//Set up non-enumerable properties of the Proxy object.
utils.InstallFunctions(GlobalProxy, DONT_ENUM, [
"createFunction", ProxyCreateFunction
]);
-%AddNamedProperty(GlobalProxy.prototype, "constructor", GlobalProxy, DONT_ENUM);
// -------------------------------------------------------------------
// Exports
« no previous file with comments | « src/js/promise.js ('k') | src/js/regexp.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698