src/crankshaft/hydrogen.cc - Issue 1448933002: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1448933002: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 41b6c148c743c64bac72c1914585f08397e3063c..b8de1db096cc09fe0839156a9dfd1be0b8f96521 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -9926,6 +9926,11 @@ void HOptimizedGraphBuilder::VisitCallNew(CallNew* expr) {

expr->IsMonomorphic() &&

IsAllocationInlineable(expr->target())) {

Handle<JSFunction> constructor = expr->target();

+ DCHECK(

+ constructor->shared()->construct_stub() ==

+ isolate()->builtins()->builtin(Builtins::kJSConstructStubGeneric) ||

+ constructor->shared()->construct_stub() ==

+ isolate()->builtins()->builtin(Builtins::kJSConstructStubApi));

HValue* check = Add<HCheckValue>(function, constructor);

// Force completion of inobject slack tracking before generating

« no previous file with comments | « src/contexts.h ('k') | src/execution.h » ('j') | no next file with comments »