src/runtime/runtime-classes.cc - Issue 1448933002: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-classes.cc

Issue 1448933002: Introduce a BuiltinsConstructStub that sets up new.target and does a [[call]] per ES6 9.3.2 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-classes.cc

diff --git a/src/runtime/runtime-classes.cc b/src/runtime/runtime-classes.cc

index dbddbefbae927a30708bca7217cc6cab06057cd6..1e132d99e21e177e3a850f000c2d092ff7463851 100644

--- a/src/runtime/runtime-classes.cc

+++ b/src/runtime/runtime-classes.cc

@@ -142,7 +142,7 @@ static MaybeHandle<Object> DefineClass(Isolate* isolate, Handle<Object> name,

constructor->shared()->set_name(*name_string);

if (!super_class->IsTheHole()) {

- Handle<Code> stub(isolate->builtins()->JSConstructStubForDerived());

+ Handle<Code> stub(isolate->builtins()->JSBuiltinsConstructStub());

Igor Sheludko 2015/11/18 09:16:07 Please add a comment about why do we use JSBuiltin

Toon Verwaest 2015/11/18 13:24:57 Done.

constructor->shared()->set_construct_stub(*stub);

}

« no previous file with comments | « src/runtime/runtime.h ('k') | src/runtime/runtime-object.cc » ('j') | src/x64/builtins-x64.cc » ('J')