Source/core/html/track/vtt/VTTRegion.h - Issue 144893002: Pass a VTTScanner to VTTRegion::parseSettingValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/vtt/VTTRegion.h

Issue 144893002: Pass a VTTScanner to VTTRegion::parseSettingValue (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: parsedEntireRun helper. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/vtt/VTTRegion.h

diff --git a/Source/core/html/track/vtt/VTTRegion.h b/Source/core/html/track/vtt/VTTRegion.h

index d37fe974b3ce1e782ec8cfa6add29b1c0841cc5a..c160162cddab63e6ca16bba3eb63628b3cee8439 100644

--- a/Source/core/html/track/vtt/VTTRegion.h

+++ b/Source/core/html/track/vtt/VTTRegion.h

@@ -114,7 +114,7 @@ private:

Scroll

};

RegionSetting scanSettingName(VTTScanner&);

- void parseSettingValue(RegionSetting, const String&);

+ void parseSettingValue(RegionSetting, VTTScanner&);

static const AtomicString& textTrackCueContainerShadowPseudoId();

static const AtomicString& textTrackCueContainerScrollingClass();

« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTRegion.cpp » ('j') | no next file with comments »