[heap] make inline-allocation-observers precise

test/cctest/test-spaces.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 816 matching lines @@
     NewSpace* new_space = i_isolate->heap()->new_space();
 
     Observer observer1(128);
     new_space->AddInlineAllocationObserver(&observer1);
 
     // The observer should not get notified if we have only allocated less than
     // 128 bytes.
     AllocateUnaligned(new_space, 64);
     CHECK_EQ(observer1.count(), 0);
 
-    // The observer should not get called even when we have allocated exactly
-    // 128 bytes.
+    // The observer should get called when we have allocated exactly 128 bytes.
     AllocateUnaligned(new_space, 64);
-    CHECK_EQ(observer1.count(), 0);
-
-    // The next allocation gets the notification.
-    AllocateUnaligned(new_space, 8);
     CHECK_EQ(observer1.count(), 1);
 
     // Another >128 bytes should get another notification.
     AllocateUnaligned(new_space, 136);
     CHECK_EQ(observer1.count(), 2);
 
     // Allocating a large object should get only one notification.
     AllocateUnaligned(new_space, 1024);
     CHECK_EQ(observer1.count(), 3);
 
-    // Allocating another 2048 bytes in small objects should get 12
+    // Allocating another 2048 bytes in small objects should get 16
     // notifications.
     for (int i = 0; i < 64; ++i) {
       AllocateUnaligned(new_space, 32);
     }
-    CHECK_EQ(observer1.count(), 15);
+    CHECK_EQ(observer1.count(), 19);
 
     // Multiple observers should work.
     Observer observer2(96);
     new_space->AddInlineAllocationObserver(&observer2);
 
     AllocateUnaligned(new_space, 2048);
-    CHECK_EQ(observer1.count(), 16);
+    CHECK_EQ(observer1.count(), 20);
     CHECK_EQ(observer2.count(), 1);
 
     AllocateUnaligned(new_space, 104);
-    CHECK_EQ(observer1.count(), 16);
+    CHECK_EQ(observer1.count(), 20);
     CHECK_EQ(observer2.count(), 2);
 
     // Callback should stop getting called after an observer is removed.
     new_space->RemoveInlineAllocationObserver(&observer1);
 
     AllocateUnaligned(new_space, 384);
-    CHECK_EQ(observer1.count(), 16);  // no more notifications.
+    CHECK_EQ(observer1.count(), 20);  // no more notifications.
     CHECK_EQ(observer2.count(), 3);   // this one is still active.
 
     new_space->RemoveInlineAllocationObserver(&observer2);
     AllocateUnaligned(new_space, 384);
-    CHECK_EQ(observer1.count(), 16);
+    CHECK_EQ(observer1.count(), 20);
     CHECK_EQ(observer2.count(), 3);
   }
   isolate->Dispose();
 }
 
 
 UNINITIALIZED_TEST(InlineAllocationObserverCadence) {
   v8::Isolate::CreateParams create_params;
   create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
   v8::Isolate* isolate = v8::Isolate::New(create_params);
@@ skipping 11 matching lines @@
     Observer observer2(576);
     new_space->AddInlineAllocationObserver(&observer2);
 
     for (int i = 0; i < 512; ++i) {
       AllocateUnaligned(new_space, 32);
     }
 
     new_space->RemoveInlineAllocationObserver(&observer1);
     new_space->RemoveInlineAllocationObserver(&observer2);
 
-    CHECK_EQ(observer1.count(), 30);
-    CHECK_EQ(observer2.count(), 26);
+    CHECK_EQ(observer1.count(), 32);
+    CHECK_EQ(observer2.count(), 28);
   }
   isolate->Dispose();
 }
 
 }  // namespace internal
 }  // namespace v8