Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1448903004:
[DevTools] One infobar per extension. (Closed)
|
Created:
5 years, 1 month ago by dgozman Modified:
5 years, 1 month ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] One infobar per extension.
BUG=555939
Committed: https://crrev.com/798856d7a317a25187cf731328797fb8279dc328
Cr-Commit-Position: refs/heads/master@{#360492}
Patch Set 1 #Patch Set 2 : nullptr #
Messages
Total messages: 24 (10 generated)
dgozman@chromium.org changed reviewers: + pfeldman@chromium.org
Take a look please.
lgtm
dgozman@chromium.org changed reviewers: + rockot@chromium.org
@rockot: could you please take a look as extensions owner?
lgtm
lgtm
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448903004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448903004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448903004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dgozman@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org, pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1448903004/#ps20001 (title: "nullptr")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448903004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448903004/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/798856d7a317a25187cf731328797fb8279dc328 Cr-Commit-Position: refs/heads/master@{#360492} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
