Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1448903002: [turbofan] Initial support for keyed access to holey elements. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for keyed access to holey elements. This adds support for load/store access to FAST_HOLEY_ELEMENTS and FAST_HOLEY_SMI_ELEMENTS backing stores. We don't currently fully support the double holes, because we make some difficult assumptions in Crankshaft there. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/59ba2a8f34dfbeeb5625757f190df5720d3a8c4b Cr-Commit-Position: refs/heads/master@{#32012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -12 lines) Patch
M src/compiler/access-info.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 8 chunks +66 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-16 14:13:44 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the initial support for holey arrays. I'll refactor that stuff tomorrow and ...
5 years, 1 month ago (2015-11-16 14:15:30 UTC) #2
Jarin
lgtm. (Yes, this is harder to read than Crankshaft at the moment, please refactor.)
5 years, 1 month ago (2015-11-16 15:49:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448903002/1
5 years, 1 month ago (2015-11-16 16:21:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 16:46:24 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:47:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59ba2a8f34dfbeeb5625757f190df5720d3a8c4b
Cr-Commit-Position: refs/heads/master@{#32012}

Powered by Google App Engine
This is Rietveld 408576698