Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1448833003: Run Oilpan GC in blink_platform_unittests. (Closed)

Created:
5 years, 1 month ago by jbroman
Modified:
5 years, 1 month ago
Reviewers:
haraken, Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run Oilpan GC in blink_platform_unittests. This fixes the issue that caused this revert: https://codereview.chromium.org/1450953002/ Essentially, this becomes the first platform unit test to have a heap-allocated mock, which we have to clean up after. This is similar to the logic in RunAllTests.cpp for webkit_unit_tests and heap_unittests. OriginAccessEntryTest is adjusted to restore the old platform so that it doesn't break subsequent tests (or in this case, the heap's attempt to clean itself up). Currently it nulls out the platform in many of its tests, and this causes code in the heap that attempts to record a histogram to crash. I've copied how PlatformTestingSupport does platform init/restore. Committed: https://crrev.com/dd85fe85c3986fd3cf647d27e23a10244126c212 Cr-Commit-Position: refs/heads/master@{#360126}

Patch Set 1 #

Patch Set 2 : technically, base/bind.h and base/bind_helpers.h are the right headers to include (rather than call… #

Total comments: 2

Patch Set 3 : move registerTraceDOMWrappers call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 2 3 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/weborigin/OriginAccessEntryTest.cpp View 15 chunks +12 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jbroman
haraken for Oilpan expertise mkwst for Source/platform/weborigin/
5 years, 1 month ago (2015-11-16 19:14:30 UTC) #3
haraken
LGTM https://codereview.chromium.org/1448833003/diff/20001/third_party/WebKit/Source/platform/testing/RunAllTests.cpp File third_party/WebKit/Source/platform/testing/RunAllTests.cpp (right): https://codereview.chromium.org/1448833003/diff/20001/third_party/WebKit/Source/platform/testing/RunAllTests.cpp#newcode58 third_party/WebKit/Source/platform/testing/RunAllTests.cpp:58: blink::ThreadState::current()->registerTraceDOMWrappers(nullptr, nullptr); This doesn't need to be called ...
5 years, 1 month ago (2015-11-16 23:30:13 UTC) #4
jbroman
https://codereview.chromium.org/1448833003/diff/20001/third_party/WebKit/Source/platform/testing/RunAllTests.cpp File third_party/WebKit/Source/platform/testing/RunAllTests.cpp (right): https://codereview.chromium.org/1448833003/diff/20001/third_party/WebKit/Source/platform/testing/RunAllTests.cpp#newcode58 third_party/WebKit/Source/platform/testing/RunAllTests.cpp:58: blink::ThreadState::current()->registerTraceDOMWrappers(nullptr, nullptr); On 2015/11/16 at 23:30:13, haraken wrote: > ...
5 years, 1 month ago (2015-11-17 16:16:52 UTC) #5
Mike West
LGTM!
5 years, 1 month ago (2015-11-17 18:47:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448833003/40001
5 years, 1 month ago (2015-11-17 19:04:37 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-17 19:10:45 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 19:11:44 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dd85fe85c3986fd3cf647d27e23a10244126c212
Cr-Commit-Position: refs/heads/master@{#360126}

Powered by Google App Engine
This is Rietveld 408576698