Fix translation of instruction "move" in ARM integrated assembler.

Fix translation of instruction "move" in ARM integrated assembler.

Fixes case where the ARM integrated assembler for class InstARM32Mov
did not revert to using the stand-alone assembler (method emit) to
generate the corresponding assembly instructions(s).

This fixes last known problem with method emitIAS (other than
reverting to the stand-alone assembler if not implemented). Removes
use of workaround flag "-unsafe-ias".

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6dacbafde57e7475bf29df2fcea208d0c0ddc7ef

[Karl, 2015-11-16 18:20:58]

Description was changed from

==========
Fix translation of instruction "move" in ARM integrated assembler.

Fixes case where the ARM integrated assembler for class InstARM32Mov
did not revert to using the stand-alone assembler (method emit) to
generate the corresponding assembly instructions(s).

This fixes last known problem with method emitIAS (other than
reverting to the stand-alone assembler if not implemented). Removes
use of workaround flag "-unsafe-ias".

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Fix translation of instruction "move" in ARM integrated assembler.

Fixes case where the ARM integrated assembler for class InstARM32Mov
did not revert to using the stand-alone assembler (method emit) to
generate the corresponding assembly instructions(s).

This fixes last known problem with method emitIAS (other than
reverting to the stand-alone assembler if not implemented). Removes
use of workaround flag "-unsafe-ias".

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-11-16 18:20:58]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-11-16 19:14:04]

lgtm

https://codereview.chromium.org/1448783004/diff/20001/src/IceClFlags.h
File src/IceClFlags.h (left):

https://codereview.chromium.org/1448783004/diff/20001/src/IceClFlags.h#oldcod...
src/IceClFlags.h:262: // TODO(kschimpf): This is a temporary flag. Nuke this
once the ARM integrated
Woohoo!!!

https://codereview.chromium.org/1448783004/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1448783004/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:805: } else
Use either "else" or "} else {" for consistency.

[Karl, 2015-11-16 20:38:16]

Committed patchset #3 (id:40001) manually as
6dacbafde57e7475bf29df2fcea208d0c0ddc7ef (presubmit successful).

[Karl, 2015-11-16 20:38:46]

https://codereview.chromium.org/1448783004/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1448783004/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:805: } else
On 2015/11/16 19:14:04, stichnot wrote:
> Use either "else" or "} else {" for consistency.

Removing "{" and "}" of then.