Fix MINIMAL=1 build

Fix MINIMAL=1 build

Lots of definitions of Target outside of asserts.

BUG=

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7f42a8243a790c8844db014b11671cb1c9406d12

[sehr, 2015-11-14 00:58:53]

Description was changed from

==========
Fix MINIMAL=1 build

Lots of definitions of Target outside of asserts.

BUG=
==========

to

==========
Fix MINIMAL=1 build

Lots of definitions of Target outside of asserts.

BUG=
==========

[sehr, 2015-11-14 00:58:53]

sehr@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[sehr, 2015-11-14 00:59:06]

Committed patchset #1 (id:1) manually as
7f42a8243a790c8844db014b11671cb1c9406d12 (presubmit successful).

[sehr, 2015-11-14 00:59:45]

I committed this TBR to you folks, because I had broken the MINIMAL build
yesterday.  Feel free to tell me how to clean this up if need be.

[Jim Stichnoth, 2015-11-14 02:42:22]

On 2015/11/14 00:59:45, sehr (please use this account) wrote:
> I committed this TBR to you folks, because I had broken the MINIMAL build
> yesterday.  Feel free to tell me how to clean this up if need be.

The usual practice is something like this:

  MyClass *X = getFoo();
  (void)X;
  assert(X);

[native-client-reviews_googlegroups.com, 2015-11-14 04:29:27]

Want me to do that and resubmit?
On Nov 13, 2015 6:42 PM, <stichnot@chromium.org> wrote:

> On 2015/11/14 00:59:45, sehr (please use this account) wrote:
>
>> I committed this TBR to you folks, because I had broken the MINIMAL build
>> yesterday.  Feel free to tell me how to clean this up if need be.
>>
>
> The usual practice is something like this:
>
>   MyClass *X = getFoo();
>   (void)X;
>   assert(X);
>
> https://codereview.chromium.org/1448673002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Jim Stichnoth, 2015-11-14 14:14:47]

On 2015/11/14 04:29:27, native-client-reviews_googlegroups.com wrote:
> Want me to do that and resubmit?

Probably, at your convenience, just in the interest of clarity.