Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 144863004: Add relTypes() to WebPrerender.h. (Closed)

Created:
6 years, 10 months ago by gavinp
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, gavinp+prerender_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add relTypes() to WebPrerender.h. We don't want to enable rel=next prerenders in blink until downstream chrome support is ready (so they don't default on); this patch allows downstream chrome patches to land before we start parsing them. R=japhet@chromium.org BUG=329963 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166761

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M Source/platform/exported/WebPrerender.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M public/platform/WebPrerender.h View 2 chunks +7 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
gavinp
japhet: PTAL. We landed https://codereview.chromium.org/116183005/ too early, because it turned on prerender for all relTypes ...
6 years, 10 months ago (2014-02-07 20:06:21 UTC) #1
Nate Chapin
LGTM, but I'm not a public/OWNER +abarth
6 years, 10 months ago (2014-02-07 20:07:32 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/144863004/diff/1/public/platform/WebPrerender.h File public/platform/WebPrerender.h (right): https://codereview.chromium.org/144863004/diff/1/public/platform/WebPrerender.h#newcode84 public/platform/WebPrerender.h:84: BLINK_PLATFORM_EXPORT unsigned relTypes() const; Often we'll typedef unsigned ...
6 years, 10 months ago (2014-02-08 01:11:33 UTC) #3
gavinp
Thank you for the review! https://codereview.chromium.org/144863004/diff/1/public/platform/WebPrerender.h File public/platform/WebPrerender.h (right): https://codereview.chromium.org/144863004/diff/1/public/platform/WebPrerender.h#newcode84 public/platform/WebPrerender.h:84: BLINK_PLATFORM_EXPORT unsigned relTypes() const; ...
6 years, 10 months ago (2014-02-08 03:28:17 UTC) #4
gavinp
The CQ bit was checked by gavinp@chromium.org
6 years, 10 months ago (2014-02-08 03:29:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/144863004/1
6 years, 10 months ago (2014-02-08 03:29:13 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-08 06:37:02 UTC) #7
Message was sent while issue was closed.
Change committed as 166761

Powered by Google App Engine
This is Rietveld 408576698