Don't use cached inherited props for distributed nodes.

Don't use cached inherited props for distributed nodes.

The -webkit-user-modify, which is inherited, does not follow normal inheritance
for distributed nodes in a shadow dom tree. Distributed nodes will have
-webkit-user-modify propagated from the shadow host overriding any inheritance
from non-distributed shadow dom nodes.

This propagation, which happens in StyleResolver::styleForElement will not be
caught will not be caught when computing the cacheHash in
StyleResolver::applyMatchedProperties and the inherited properties might
incorrectly be shared, effectively cancelling out the -webkit-user-modify
propagation.

R=esprehn
BUG=339463
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166414

[rune, 2014-01-30 14:16:31]

Issue caused regression in, and split out from:

https://codereview.chromium.org/135183002/

[esprehn, 2014-01-30 16:35:32]

This is going to disable the matches properties cache for a lot of elements
in web component heavy apps like polymer. Can we just disable the cache for
styles that have user-modify set?

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rune, 2014-01-30 17:19:23]

On 2014/01/30 16:35:32, esprehn wrote:
> This is going to disable the matches properties cache for a lot of elements
> in web component heavy apps like polymer. Can we just disable the cache for
> styles that have user-modify set?

Done that now.

The test-case in this change still passes with that change. Now, there will be
some cases that still do incorrect use of the cache, I think. If you have
(excuse my syntax):


<div contentEditable="false">XXX</div>


with the following shadow dom:


<shadow-root>
  <div contentEditable>
    <div></div>
    <content></content>
  </div>
</shadow-root>


you will have the XXX editable because the contentEditable="false" forced on the
distributed node will be overridden by using the cached inherited
contentEditable from the outer to the inner div of the shadow dom.

I don't even know what's the correct behavior here.

[dglazkov, 2014-02-03 22:40:11]

lgtm

[rune, 2014-02-03 22:45:20]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-02-03 22:45:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/144853004/20001

[commit-bot: I haz the power, 2014-02-03 23:57:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-03 23:57:19]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-02-03 23:57:24]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:57:24]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:57:25]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:57:29]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 23:59:56]

CQ bit was unchecked on CL. Ignoring.

[rune, 2014-02-04 08:04:51]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-02-04 08:05:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/144853004/20001

[commit-bot: I haz the power, 2014-02-04 11:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 11:06:02]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[rune, 2014-02-04 11:37:41]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-02-04 11:37:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/144853004/20001

[commit-bot: I haz the power, 2014-02-04 14:13:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 14:13:23]

Retried try job too often on linux_blink for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[skia-commit-bot, 2014-02-04 14:13:25]

CQ bit was unchecked on CL. Ignoring.

[rune, 2014-02-04 14:48:01]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-02-04 14:48:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/144853004/20001

[commit-bot: I haz the power, 2014-02-04 16:34:17]

Change committed as 166414

[skia-commit-bot, 2014-02-04 16:34:22]

CQ bit was unchecked on CL. Ignoring.