Issue 14485002: Get the OpenGLUI emulator building again on the desktop. Mostly this is applying the changes here:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14485002: Get the OpenGLUI emulator building again on the desktop. Mostly this is applying the changes here: (Closed)

Created:
7 years, 8 months ago by gram

Modified:
7 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Get the OpenGLUI emulator building again on the desktop. Mostly this is applying the changes here: https://code.google.com/p/dart/issues/detail?id=9961 I also added a few Skia libraries to the emulator to make them consistent with the embedder library. I had to apt-get install libgif-devel to get this to build. Currently the Android build is broken. We seem to have a mix of x64 and ia32 breaking the link. I'm not sure why this is happening yet, but it may be related to a recent Skia change for Android. See https://groups.google.com/d/topic/skia-discuss/lSrgomxplqo/discussion for details. Related to that, you will need to do apt-get install gsutil to buld Skia for Android. Committed: https://code.google.com/p/dart/source/detail?r=22046

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -10 lines)			Patch
M	runtime/embedders/openglui/common/extension.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	runtime/embedders/openglui/common/vm_glue.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/embedders/openglui/common/vm_glue.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/embedders/openglui/openglui_embedder.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/openglui/emulator/emulator.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	samples/sample_extension/sample_extension.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r22046.

Expand Messages | Collapse Messages