Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1448463004: Cleanups. More mutator thread asserts. (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Total comments: 4

Patch Set 3 : e #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -45 lines) Patch
M runtime/vm/assembler_x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/vm/class_table.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 1 5 chunks +22 lines, -20 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object_store.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 1 month ago (2015-11-13 23:51:17 UTC) #2
siva
lgtm https://codereview.chromium.org/1448463004/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1448463004/diff/20001/runtime/vm/compiler.cc#newcode820 runtime/vm/compiler.cc:820: for (intptr_t i = 0; Can you add ...
5 years, 1 month ago (2015-11-14 01:44:38 UTC) #3
srdjan
https://codereview.chromium.org/1448463004/diff/20001/runtime/vm/compiler.cc File runtime/vm/compiler.cc (right): https://codereview.chromium.org/1448463004/diff/20001/runtime/vm/compiler.cc#newcode820 runtime/vm/compiler.cc:820: for (intptr_t i = 0; On 2015/11/14 01:44:38, siva ...
5 years, 1 month ago (2015-11-16 17:25:51 UTC) #4
srdjan
5 years, 1 month ago (2015-11-16 18:29:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
354fcb12cf81c216955ac204a3f913139b6c4381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698