Convert drawText to using the find and place code.

Convert drawText to using the find and place code.
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/e59124ed1a62f1fec79679c38cabed622a756f75

[herb_g, 2015-11-13 19:48:25]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 19:48:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448453002/20001

[commit-bot: I haz the power, 2015-11-13 19:49:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 19:49:22]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[herb_g, 2015-11-13 19:57:03]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-13 19:57:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448453002/40001

[commit-bot: I haz the power, 2015-11-13 20:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 20:08:53]

Dry run: This issue passed the CQ dry run.

[herb_g, 2015-11-13 20:31:46]

There are 9 gold changes that all look different rounding in the move from fixed
to float in the placement loop.

https://gold.skia.org/search2?issue=1448453002&unt=true&query=source_type%3Dg...

[herb_g, 2015-11-16 21:04:54]

Description was changed from

==========
Convert drawText to using the find and place code.
BUG=skia:
==========

to

==========
Convert drawText to using the find and place code.
BUG=skia:
==========

[herb_g, 2015-11-16 21:04:54]

herb@google.com changed reviewers:
+ joshualitt@google.com, mtklein@google.com

[joshualitt, 2015-11-17 16:10:02]

On 2015/11/16 21:05:07, herb_g wrote:

Atlas part looks good

[mtklein, 2015-11-17 20:34:48]

You're sure the diffs are just rounding?  This first one looks quite noticeable:
https://gold.skia.org/search2?issue=1448453002&unt=true&query=source_type%3Dg...

[mtklein, 2015-11-17 20:37:34]

https://codereview.chromium.org/1448453002/diff/40001/src/core/SkDraw.cpp
File src/core/SkDraw.cpp (right):

https://codereview.chromium.org/1448453002/diff/40001/src/core/SkDraw.cpp#new...
src/core/SkDraw.cpp:1606: proc(d1g, SkScalarToFixed(position.fX),
SkScalarToFixed(position.fY), glyph);
Should we not be calling SkScalarTo48Dot16 here?

[herb_g, 2015-11-18 18:24:16]

change the type to draw one glyph

[herb_g, 2015-11-18 18:26:06]

I checked the letter you pointed out. This is a rounding difference. The
position in fixedpoint is 83.9999847. And the SkScalar value is 84.

https://codereview.chromium.org/1448453002/diff/40001/src/core/SkDraw.cpp
File src/core/SkDraw.cpp (right):

https://codereview.chromium.org/1448453002/diff/40001/src/core/SkDraw.cpp#new...
src/core/SkDraw.cpp:1606: proc(d1g, SkScalarToFixed(position.fX),
SkScalarToFixed(position.fY), glyph);
On 2015/11/17 20:37:34, mtklein wrote:
> Should we not be calling SkScalarTo48Dot16 here?

Done.

[mtklein, 2015-11-18 18:29:32]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-11-18 18:29:33]

lgtm

[commit-bot: I haz the power, 2015-11-18 18:29:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448453002/60001

[herb_g, 2015-11-18 18:36:14]

The CQ bit was unchecked by herb@google.com

[herb_g, 2015-11-18 18:38:12]

Remove adjusted test.

[herb_g, 2015-11-18 18:38:29]

The CQ bit was checked by herb@google.com

[herb_g, 2015-11-18 18:38:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1448453002/#ps80001
(title: "Remove adjusted test.")

[commit-bot: I haz the power, 2015-11-18 18:38:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1448453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1448453002/80001

[commit-bot: I haz the power, 2015-11-18 18:54:41]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/e59124ed1a62f1fec79679c38cabed622a756f75