components/omnibox/browser/omnibox_view.h - Issue 1448433004: [MD] update EV bubble icon and location bar https icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_view.h

Issue 1448433004: [MD] update EV bubble icon and location bar https icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/location_bar_view.cc ('K') | « chrome/browser/ui/views/location_bar/selected_keyword_view.cc ('k') | components/omnibox/browser/omnibox_view.cc » ('j') | components/omnibox/browser/omnibox_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/omnibox_view.h

diff --git a/components/omnibox/browser/omnibox_view.h b/components/omnibox/browser/omnibox_view.h

index 6095561e3ff3f9648358a36cc9ff68fd6ba2813a..75d46b3e9387076bfb9fe2ba0bab8ecffa62454d 100644

--- a/components/omnibox/browser/omnibox_view.h

+++ b/components/omnibox/browser/omnibox_view.h

@@ -75,8 +75,9 @@ class OmniboxView {

// Returns the resource ID of the icon to show for the current text.

int GetIcon() const;

- // Like GetIcon(), but returns a vector icon identifier.

- gfx::VectorIconId GetVectorIcon() const;

+ // Like GetIcon(), but returns a vector icon identifier. The icon may

+ // change in a dark theme, hence |invert|.

Peter Kasting 2015/11/17 21:27:03 Nit: Maybe this second sentence: "If |invert| is t

Evan Stade 2015/11/17 22:57:21 Done.

+ gfx::VectorIconId GetVectorIcon(bool invert) const;

// The user text is the text the user has manually keyed in. When present,

// this is shown in preference to the permanent text; hitting escape will