Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1448383002: MIPS: Implementation of Float64RoundUp and Float64RoundTiesEven (Closed)

Created:
5 years, 1 month ago by ivica.bogosavljevic
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Implementation of Float64RoundUp and Float64RoundTiesEven Port 1389b9f53c90dca1ff123cf3a1e90c607dadfc90 Port dffecf31fc069c9522bcb09df7c063a9710f6470 Implementation of two optional turbofan operators Float64RoundUp and Float64RoundTiesEven on MIPS32. On MIPS32R2 with FP64 and MIPS32R6 with FP64 we can support these two operators directly using MIPS instructions. This code implements these two operators. Also, added some DCHECKs for instructions which are supported on MIPS32R2 with FP64 and MIPS32R6 with FP64 to detect wrong usage on unsupported architectures. BUG= Committed: https://crrev.com/5e9c4716d158aced80fa5c7306468909a621082a Cr-Commit-Position: refs/heads/master@{#32108}

Patch Set 1 #

Patch Set 2 : Fixing CLINT warning on function size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -10 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 3 chunks +12 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
paul.l...
nits: please edit title to "MIPS: Implementation of ...". No brackets on per-arch ports. And ...
5 years, 1 month ago (2015-11-19 00:09:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448383002/1
5 years, 1 month ago (2015-11-19 08:51:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7880)
5 years, 1 month ago (2015-11-19 08:54:08 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448383002/20001
5 years, 1 month ago (2015-11-19 10:15:29 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 10:35:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448383002/20001
5 years, 1 month ago (2015-11-19 10:39:03 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 10:40:20 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5e9c4716d158aced80fa5c7306468909a621082a Cr-Commit-Position: refs/heads/master@{#32108}
5 years, 1 month ago (2015-11-19 10:40:36 UTC) #19
Igor Sheludko
5 years, 1 month ago (2015-11-19 14:29:04 UTC) #20
Message was sent while issue was closed.
On 2015/11/19 at 10:40:36, commit-bot wrote:
> Patchset 2 (id:??) landed as
https://crrev.com/5e9c4716d158aced80fa5c7306468909a621082a
> Cr-Commit-Position: refs/heads/master@{#32108}

This CL breaks several cctests in [opt]debug mode. For example:
cctest/test-assembler-mips/CVT

Powered by Google App Engine
This is Rietveld 408576698